1926753 - [wpt-sync] Sync PR 48794 - IntersectionObserver -- properly handle "unknown" occlusion state

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48794 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48794
Details from upstream follow.

Stefan Zager <[e-mail]> wrote:

IntersectionObserver -- properly handle "unknown" occlusion state

If we most recently reported a target as "guaranteed visible", then in
the interest of avoiding false positives we must transition to "not
guaranteed visible" if the frame occlusion state becomes "unknown".

This CL also makes a child frame inherit its parent's "not visible"
occlusion state rather than calling it "unknown", which is technically
more correct.

Bug: chromium:371247941
Change-Id: I4d721dd252d013deac14a12f1f2922830ef2a8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5950965
Reviewed-by: Xianzhu Wang \<[e-mail]>
Commit-Queue: Stefan Zager \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1373093}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e9c2c36d5af60a2c48575f95e43fa55b5359694

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 1 subtests

Status Summary

Firefox

OK : 3
FAIL: 3

Chrome

OK : 3
PASS: 3

Safari

OK : 3
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /intersection-observer/v2/cross-origin-effects.sub.html [wpt.fyi]
  • Intersection observer V2 test with visual effects on iframe.: FAIL (Chrome: PASS, Safari: FAIL)
• /intersection-observer/v2/cross-origin-occlusion.sub.html [wpt.fyi]
  • Intersection observer V2 test with occlusion of target in iframe.: FAIL (Chrome: PASS, Safari: FAIL)
• /intersection-observer/v2/nested-cross-origin.sub.html [wpt.fyi]
  • Intersection observer V2 test with nested cross-origin iframes.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4bab3bf42e6
[wpt PR 48794] - IntersectionObserver -- properly handle "unknown" occlusion state, a=testonly
https://hg.mozilla.org/integration/autoland/rev/64b20d04bfd0
[wpt PR 48794] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b4bab3bf42e6
https://hg.mozilla.org/mozilla-central/rev/64b20d04bfd0