amIAddonManager interface is nothing
Categories
(Toolkit :: Add-ons Manager, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox134 | --- | fixed |
People
(Reporter: m_kato, Assigned: enoki.lucas, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
https://searchfox.org/mozilla-central/rev/abe6e3de6850eca664e968484f8ecfc53487ea42/toolkit/mozapps/extensions/amManager.sys.mjs#323 is trying to register amIAddonManager interface for QI, but his interface is removed.
So we should remove this meaningless QI parameter.
|
||
Comment 1•3 months ago
|
||
For the record, the interface was removed in bug 1445551, specifically https://hg.mozilla.org/mozilla-central/rev/f52c1d6859be#l16.1
To resolve the bug, it suffices to remove the line mentioned in the initial comment (and maybe remove a few line breaks if prettier prefers to put the array content and function call on one line).
|
Assignee | |
Comment 2•3 months ago
|
||
Hello! New contributor here. I'd like to take on this bug if that is possible.
Could I get assigned?
|
|
||
Comment 3•3 months ago
|
||
Hi Lucas,
When you attach a patch, a bot will automatically assign the bug to you.
To get started, you need to check out the code. You can find instructions at https://wiki.mozilla.org/WebExtensions/Contribution_Onramp
Usually you need to build and run tests to verify the patch, but because I already verified that this is dead code, and no functional impact is expected from removing the line, the work needed becomes simpler - just remove one line of code, create a commit and then submit a patch.
Please give that a try, and let me know if you need more help!
|
|
Assignee | |
Comment 4•3 months ago
|
||
The amIAddonManager interface was removed in Bug 1445551, but the registration was left in amManager.sys.mjs. This patch removes the now-unused QI parameter, as it no longer serves any purpose.
|
||
Updated•3 months ago
|
Description
•