1926794 - Umatched selectors, overridden/inactive declarations don't have distinct color in High Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

We can use GrayText for those

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1926794 - [devtools] Replace incorrect usage of --theme-text-color-inactive. r=#devtools.

The variable was used in a few places for elements that are not inactive.
It was probably picked because of its lighter color, but we do have
specific variable for that (for text and icons), that are better suited
and already adapt to High Contrast Mode.
In one case, the rule using it wasn't even used, so I removed it completely.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1926794 - [devtools] Use GrayText for unmatched selector, unused and overridden declarations in High Contrast Mode. r=#devtools.

We're setting --theme-text-color-inactive to GrayText in HCM,
and we use this variable for styling unused/inactive items in
the Rules view, as we still want --theme-text-color-alt to have
the default canvas text in HCM.
In non-HCM, --theme-text-color-inactive was lacking contrast
against the usual background, so it's updated to have
sufficient contrast.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Inspector: Rules' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e3b74a648bb
[devtools] Replace incorrect usage of --theme-text-color-inactive. r=devtools-reviewers,bomsy.
https://hg.mozilla.org/integration/autoland/rev/1e442fe98563
[devtools] Use GrayText for unmatched selector, unused and overridden declarations in High Contrast Mode. r=devtools-reviewers,bomsy.

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7e3b74a648bb
https://hg.mozilla.org/mozilla-central/rev/1e442fe98563