Generate a block per line in view-source highlighter.
Categories
(Toolkit :: View Source, enhancement)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 6 obsolete files)
Generate a block per line in view-source highlighter.
This would at least help with bug 1926808. Right now we generate a single <pre>
, and then have a <span>
per line. That causes things like the BiDi algorithm to deal with the whole document at one time, afaict.
There's no reason for that, we could output one <pre>
per line, and that should make laying out view-source faster.
This would be a more minimal change compared to bug 1926820. Maybe worth doing sooner?
Assignee | ||
Updated•16 days ago
|
Assignee | ||
Comment 1•15 days ago
|
||
Updated•15 days ago
|
Assignee | ||
Comment 2•15 days ago
|
||
Assignee | ||
Comment 3•15 days ago
|
||
This makes viewing source of the HTML spec usable.
Assignee | ||
Comment 4•15 days ago
|
||
This is not needed since bug 1919205.
Assignee | ||
Comment 5•15 days ago
|
||
This is always loaded in HTML and there's no user-controlled content, so
we're good.
Assignee | ||
Comment 6•15 days ago
|
||
After the previous patches we never set the line for span elements, we
always create a <pre>.
Assignee | ||
Comment 7•15 days ago
|
||
Use -moz-bool-pref for them and simplify all the back and forth. Use
light-dark() while at it.
Comment 8•15 days ago
|
||
Comment on attachment 9433116 [details]
Bug 1926824 - Remove unneeded @charset in viewsource.css. r=#style
Revision D226795 was moved to bug 1926922. Setting attachment 9433116 [details] to obsolete.
Comment 9•15 days ago
|
||
Comment on attachment 9433117 [details]
Bug 1926824 - Remove unneeded @namespace in viewsource.css. r=#style
Revision D226796 was moved to bug 1926922. Setting attachment 9433117 [details] to obsolete.
Comment 10•15 days ago
|
||
Comment on attachment 9433119 [details]
Bug 1926824 - Simplify view-source wrapping and syntax highlighting preferences. r=Gijs,#style
Revision D226798 was moved to bug 1926922. Setting attachment 9433119 [details] to obsolete.
Comment 11•15 days ago
|
||
Comment on attachment 9433113 [details]
Bug 1926824 - Use string literals rather than statics in nsHtml5Highlighter.cpp. r=smaug,hsivonen
Revision D226792 was moved to bug 1926922. Setting attachment 9433113 [details] to obsolete.
Comment 12•15 days ago
|
||
Comment on attachment 9433114 [details]
Bug 1926824 - Remove some unused code in nsHtml5Highlighter. r=smaug,hsivonen
Revision D226793 was moved to bug 1926922. Setting attachment 9433114 [details] to obsolete.
Comment 13•15 days ago
|
||
Comment 14•14 days ago
|
||
Backed out changeset fd1ad91ca6ed (bug 1926824) for causing reftest failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/835d93c1dc201b16b41de7eb9b7f6ab8ba8f51ee
Comment 15•14 days ago
|
||
Assignee | ||
Comment 16•14 days ago
|
||
Not a huge priority, but do you know what the best way to regenerate the view-source reftests is?
https://phabricator.services.mozilla.com/D226797 breaks them because the references stop matching the span[id]
stuff of course...
Assignee | ||
Comment 17•14 days ago
|
||
I guess Ctrl+S might do...
Comment 18•14 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7b4d4dd97112
https://hg.mozilla.org/mozilla-central/rev/46d6710781aa
Assignee | ||
Comment 19•12 days ago
|
||
Can we back this out from beta once the merge happens for causing a copy-paste regression?
Assignee | ||
Comment 20•12 days ago
|
||
(ah, aryx mentioned it's not necessary to ni? :))
Comment 21•11 days ago
•
|
||
Backed out of beta for causing Bug 1927404
https://hg.mozilla.org/releases/mozilla-beta/rev/140c5c7b94215e7ee54ce2b742bd0845e1ea8157
Comment 22•11 days ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #16)
Not a huge priority, but do you know what the best way to regenerate the view-source reftests is?
I don't recall for sure, but I think I've done Select All followed by View Selection Source on View Source itself.
Assignee | ||
Comment 23•11 days ago
|
||
I ended up biting the bullet in bug 1927404 and just editing them since some of them had manual tweaks like line numbers removed etc.
Updated•9 days ago
|
Description
•