1926833 - Crash in [@ java.lang.NullPointerException: at org.mozilla.fenix.components.menu.MenuDialogFragment.getBrowsingModeManager$1(MenuDialogFragment.kt:7)]

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P3)

Description

[eclaudiu64]

Crash report: https://crash-stats.mozilla.org/report/index/1822937f-e91f-4e9d-8a2e-663cd0241024

Top 9 frames:

0  org.mozilla.fenix.components.menu.MenuDialogFragment  getBrowsingModeManager$1  MenuDialogFragment.kt:7
1  org.mozilla.fenix.components.menu.MenuDialogFragment$$ExternalSyntheticLambda0  onShow  R8$$SyntheticClass:10
2  android.app.Dialog$ListenersHandler  handleMessage  Dialog.java:1747
3  android.os.Handler  dispatchMessage  Handler.java:106
4  android.os.Looper  loop  Looper.java:246
5  android.app.ActivityThread  main  ActivityThread.java:8653
6  java.lang.reflect.Method  invoke  Method.java:-2
7  com.android.internal.os.RuntimeInit$MethodAndArgsCaller  run  RuntimeInit.java:602
8  com.android.internal.os.ZygoteInit  main  ZygoteInit.java:1130

Comment 1

[Chris Peterson [:cpeterson]]

Thanks for reporting this crash! Even though the exception mentions "HomeActivity", the stack trace looks like a menu bug.

java.lang.NullPointerException: null cannot be cast to non-null type org.mozilla.fenix.HomeActivity

Comment 2

[Iorga Gabriel]

Attachment: Bug 1926833 - Don't crash if browsing mode manager is not available.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Deobfuscated stack trace:

java.lang.NullPointerException: null cannot be cast to non-null type org.mozilla.fenix.HomeActivity
at org.mozilla.fenix.components.menu.MenuDialogFragment.getBrowsingModeManager(MenuDialogFragment.kt:99)
at org.mozilla.fenix.components.menu.MenuDialogFragment.onCreateDialog$lambda$2$lambda$1(MenuDialogFragment.kt:108)
at android.app.Dialog$ListenersHandler.handleMessage(Dialog.java:1747)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:246)
at android.app.ActivityThread.main(ActivityThread.java:8653)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:602)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d7be0762141
Don't crash if browsing mode manager is not available. r=android-reviewers,petru

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/4d7be0762141