1926834 - getTabTooltip should cache value of pid pref

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[:Gijs (he/him)]

In the profile in bug 1923363 I'm seeing a ton of markers for pref reads of browser.tabs.tooltipsShowPidAndActiveness which appear to be coming from https://searchfox.org/mozilla-central/rev/dca2603d55b5b39d3b8ab8e93c08b42563f5aad8/browser/components/tabbrowser/content/tabbrowser.js#6179-6184 .

That pref read should be cached instead of running once for each tab and its tooltip. In the list-all-tabs code that getter gets called for each tab, cf. https://searchfox.org/mozilla-central/rev/dca2603d55b5b39d3b8ab8e93c08b42563f5aad8/browser/components/tabbrowser/TabsList.sys.mjs#358 .

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1926834 - put pid pref getter on tabbrowser and use from both tab hover previews and tabbrowser itself, r?mconley!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2cac32dfe56
put pid pref getter on tabbrowser and use from both tab hover previews and tabbrowser itself, r=tabbrowser-reviewers,dao

Comment 3

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/f2cac32dfe56