1926851 - Rules view dirty/new indicator is always displayed in high Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

The indicator is created with a left border, which is transparent by default, and gets turned green when the property is updated.
in High Contrast Mode , transparent is transformed into a solid color, and so the indicator is always visible, making the declarations look weird

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1926851 - [devtools] Handle dirty/new indicator on declaration in High Contrast Mode. r=#devtools.

The indicator was always visible because transparent is forced
into an actual solid color in HCM, and the border is always set
to avoid layout shifts when a declaration becomes updated.
This is fixed by opting out of forced colors just for the declaration
top element, and re-setting it again for children.
The colors used for the indicator, --theme-highlight-green, is properly
set to a high contrast color in HCM.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03ae30f42356
[devtools] Handle dirty/new indicator on declaration in High Contrast Mode. r=devtools-reviewers,bomsy.

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/03ae30f42356