1926852 - Rules view property name/value hover dashed underline is always visible in high Contrast Mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

The dashed line should only be shown on hover, but it's created with a bottom border, which is transparent by default, and gets turned grey on hover.
in High Contrast Mode , transparent is transformed into a solid color, and so the line is always visible, even when properties are not hovered

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1926852 - [devtools] Use text-decoration to indicate editable items in Rules view declaration. r=#devtools.

Using text-decoration allows us to only do it on hover, as it doesn't
triggers a layout shift (contrary to bottom border). This way, it also
prevent always showing the border in High Contrast Mode, where transparent
color is ignored.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc5dac32dbd7
[devtools] Use text-decoration to indicate editable items in Rules view declaration. r=devtools-reviewers,bomsy.

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/bc5dac32dbd7