Closed
Bug 1926946
Opened 24 days ago
Closed 10 days ago
Errors in SelectableProfileService theme observer when setting theme to system default
Categories
(Toolkit :: Startup and Profile System, defect, P1)
Toolkit
Startup and Profile System
Tracking
()
RESOLVED
FIXED
134 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr128 | --- | unaffected |
| firefox131 | --- | unaffected |
| firefox132 | --- | unaffected |
| firefox133 | --- | disabled |
| firefox134 | --- | fixed |
People
(Reporter: niklas, Assigned: niklas)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-profile-management] )
Attachments
(1 file)
colors are set on theme in the system default. We need a special case when a theme is set to system default and we are in light mode.
|
Assignee | |
Comment 1•24 days ago
|
||
|
||
Comment 2•24 days ago
|
||
Set release status flags based on info from the regressing bug 1925098
status-firefox131:
--- → unaffected
status-firefox132:
--- → unaffected
status-firefox133:
--- → affected
status-firefox-esr128:
--- → unaffected
|
|
||
Comment 3•19 days ago
|
||
Set release status flags based on info from the regressing bug 1925098
status-firefox134:
--- → affected
|
||
Updated•19 days ago
|
Whiteboard: [fidefe-profile-management]
|
||
Updated•19 days ago
|
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/84377da985ab
Add special case for setting theme to system deault in SelectableProfileService. r=jhirsch,emilio
|
||
Comment 6•11 days ago
|
||
Backed out for causing bc failures @ browser_notify_changes.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/482f96347ac0d905af5803741fd5f5f08552d3d8
Flags: needinfo?(nbaumgardner)
|
|
||
Updated•11 days ago
|
Whiteboard: [fidefe-profile-management] → [fidefe-profile-management]
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd314151fbac
Add special case for setting theme to system deault in SelectableProfileService. r=jhirsch,emilio
|
||
Comment 8•10 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
|
||
Comment 9•10 days ago
|
||
:niklas does this need a beta uplift request or can it ride the train?
|
|
Assignee | |
Comment 10•5 days ago
•
|
||
(In reply to Donal Meehan [:dmeehan] from comment #9)
:niklas does this need a beta uplift request or can it ride the train?
No, this is behind a build flag in 133. We can ride the train
Flags: needinfo?(nbaumgardner)
|
|
||
Updated•5 days ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•