1926970 - 7.18 - 2.15% Heap Unclassified / Explicit Memory (Windows) regression on Thu October 17 2024

Status: NEW

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Treeherder Bug Filer]

Perfherder has detected a awsy performance regression from push fe10049200dfa92f958f65b9fc37fef345694b41. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
7%	Heap Unclassified	windows11-64-2009-shippable-qr	fission tp6	106,579,562.77 -> 114,232,611.55
2%	Explicit Memory	windows11-64-2009-shippable-qr	fission tp6	498,735,945.21 -> 509,445,556.34

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 2530

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to [e-mail].

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910138

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910138

Comment 3

[Lee Salzman [:lsalzman]]

This shouldn't be that big an issue, but we had done some previous work on this in bug 1905674. Brad, is this something you would be taking another look at?

Comment 4

[Brad Werth [:bradwerth]]

Yes, I'll see if we can mark up the memory better to understand this growth in unclassified memory.

Comment 5

[Andrew McCreight [:mccr8]]

The explicit memory also went up a decent amount, though perhaps that's expected. If the resident didn't also go up, then maybe that just means that graphics memory is now being allocated by Gecko whereas it was being allocated by a driver before or something.