1927069 - `mach try release [...] --migration 'release-to-esr` should not accept release version numbers

Status: REOPENED

(Release Engineering :: General, enhancement, P5)

Description

[Johan Lorenzo [:jlorenzo]]

I discovered it while testing bug 1860752 comment 63.

Steps to reproduce

1. ./mach try release --migration 'central-to-beta' --migration 'beta-to-release' --migration 'release-to-esr' --version "$(cat browser/config/version.txt | sed 's/a1/esr/')" ➡️ See the error message mach try release: error: argument -v/--version: invalid parse value: '133.0esr'
2. Run the same command without replacing a1 by esr but by just stripping it instead. ./mach try release --migration 'central-to-beta' --migration 'beta-to-release' --migration 'release-to-esr' --version "$(cat browser/config/version.txt | sed 's/a1//')"

Expected results

Given that mach try release doesn't allow me to specify esr in the version number, I expect the command to be smart enough to ensure the version number is correct everywhere, especially in version_display.txt where esr must be provided[1]. version.txt must not have it[2].

Actual results

version.txt has the right value but version_display.txt doesn't have esr in it[3].

Additional context

--migration 'release-to-esr' was added in bug 1551738 and I suspect this bug has flown under the radar since then. I'm filing it in order to document it.

[1] https://hg.mozilla.org/releases/mozilla-esr128/file/36cf46e09178013aa328b8ab4d3b745bd33697e2/browser/config/version_display.txt#l1
[2] https://hg.mozilla.org/releases/mozilla-esr128/file/36cf46e09178013aa328b8ab4d3b745bd33697e2/browser/config/version.txt#l1
[3] https://hg.mozilla.org/try/rev/52f4e8ab5a5e505580b5a8fd682455158b2f6027#l8.1

Comment 1

[Julien Cristau [:jcristau]]

The reason your first command fails is because mozilla_version doesn't like 133 as an ESR.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Oh, that's right 🤦‍♂️ 128.99.0esr works much better![1]

In that case, 133.0 shouldn't be considered a valid ESR version either. I'm reopening this bug to keep track of it.

Steps to reproduce

1. ./mach try release --migration 'central-to-beta' --migration 'beta-to-release' --migration 'release-to-esr' --version "133.0"

Expected results

An error message telling the user 133.0 is not a valid ESR version number

Actual results

No error is raised and the try-push is submitted[2]

[1] https://hg.mozilla.org/try/rev/a94a7725a73611b29bc1391061776337d9faaf4a#l9.5
[2] https://hg.mozilla.org/try/rev/52f4e8ab5a5e505580b5a8fd682455158b2f6027#l8.1