Closed Bug 1927195 Opened 4 months ago Closed 3 months ago

Turn on explicit resource management build config in nightly

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: debadree333, Assigned: debadree333)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 10 obsolete files)

Bug 1927195 - Enable explicit resource build management flag based on nightly flag. r?arai!
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → debadree333
Status: NEW → ASSIGNED
Attachment #9433540 - Attachment description: Bug 1927195 - Part 2: Mark all explicit resource jit-tests to skip by shell option. r?arai! → Bug 1927195 - Part 2: Pass shell option in explicit resource management jit-tests. r?arai!
Attachment #9434814 - Attachment description: Bug 1927195 - Part 9: Set Wrapper::defaultProto as MOZ_GLOBINIT to prevent clang-tidy error. r?sergesanspaille! → Bug 1927195 - Part 0: Set Wrapper::defaultProto as MOZ_GLOBINIT to prevent clang-tidy error. r?sergesanspaille!

Depends on D227666

Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/a619c4f804ae Part 0: Set Wrapper::defaultProto as MOZ_GLOBINIT to prevent clang-tidy error. r=sergesanspaille https://hg.mozilla.org/integration/autoland/rev/e33308b4d926 Part 1: Add a static pref & shell option for explicit resource management proposal. r=arai https://hg.mozilla.org/integration/autoland/rev/ce53cf8941e8 Part 2: Pass shell option in explicit resource management jit-tests. r=arai https://hg.mozilla.org/integration/autoland/rev/c0cc438b2397 Part 3: Skip adding explicit resource management globals based on pref. r=arai https://hg.mozilla.org/integration/autoland/rev/0174baa33cf7 Part 4: Prevent parsing using & await using syntax based on pref. r=arai https://hg.mozilla.org/integration/autoland/rev/e04106cc17e7 Part 5: Remove explicit resource management build requirement from regexp test. r=arai https://hg.mozilla.org/integration/autoland/rev/d614cfbf6184 Part 6: Enable explicit resource management flag based on nightly flag. r=arai https://hg.mozilla.org/integration/autoland/rev/b2a70e61e3c6 Part 7: Add a shell option to disable explicit resource management. r=arai https://hg.mozilla.org/integration/autoland/rev/83f833fd0492 Part 8: Add tests for when explicit resource management parsing is disabled. r=arai https://hg.mozilla.org/integration/autoland/rev/bb39fc209560 Part 9: Update existing test262 tests to pass shell option. r=arai https://hg.mozilla.org/integration/autoland/rev/8e469bc7f4db Part 10: Fix hazard analysis errors by making getOrCreateDisposeCapability a static method. r=arai

Backed out for causing build bustages.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/js/xpconnect/wrappers/XrayWrapper.cpp:51:15: error: static assertion failed due to requirement 'JSProto_URIError - JSProto_Error == 8': New prototype added in error object range

Please also check these sm bustages.

Flags: needinfo?(debadree333)
See Also: → 1928870
Depends on: 1929031
No longer depends on: 1929031
Flags: needinfo?(debadree333)
Summary: Prepare Explicit Resource Management proposal for nightly → Turn on explicit resource management in nightly
Summary: Turn on explicit resource management in nightly → Turn on explicit resource management build config in nightly

Comment on attachment 9434814 [details]
Bug 1927195 - Part 0: Set Wrapper::defaultProto as MOZ_GLOBINIT to prevent clang-tidy error. r?sergesanspaille!

Revision D227667 was moved to bug 1929034. Setting attachment 9434814 [details] to obsolete.

Attachment #9434814 - Attachment is obsolete: true

Comment on attachment 9434970 [details]
Bug 1927195 - Part 10: Fix hazard analysis errors by making getOrCreateDisposeCapability a static method. r?arai!

Revision D227770 was moved to bug 1929037. Setting attachment 9434970 [details] to obsolete.

Attachment #9434970 - Attachment is obsolete: true

Comment on attachment 9433543 [details]
Bug 1927195 - Part 5: Remove explicit resource management build requirement from regexp test. r?arai!

Revision D226995 was moved to bug 1929049. Setting attachment 9433543 [details] to obsolete.

Attachment #9433543 - Attachment is obsolete: true

Comment on attachment 9433539 [details]
Bug 1927195 - Part 1: Add a static pref & shell option for explicit resource management proposal. r?arai!

Revision D226991 was moved to bug 1929031. Setting attachment 9433539 [details] to obsolete.

Attachment #9433539 - Attachment is obsolete: true

Comment on attachment 9434418 [details]
Bug 1927195 - Part 7: Add a shell option to disable explicit resource management. r?arai!

Revision D227447 was moved to bug 1929031. Setting attachment 9434418 [details] to obsolete.

Attachment #9434418 - Attachment is obsolete: true

Comment on attachment 9433540 [details]
Bug 1927195 - Part 2: Pass shell option in explicit resource management jit-tests. r?arai!

Revision D226992 was moved to bug 1929045. Setting attachment 9433540 [details] to obsolete.

Attachment #9433540 - Attachment is obsolete: true

Comment on attachment 9434886 [details]
Bug 1927195 - Part 9: Update existing test262 tests to pass shell option. r?arai!

Revision D227718 was moved to bug 1929045. Setting attachment 9434886 [details] to obsolete.

Attachment #9434886 - Attachment is obsolete: true

Comment on attachment 9433541 [details]
Bug 1927195 - Part 3: Skip adding explicit resource management globals based on pref. r?arai!

Revision D226993 was moved to bug 1929045. Setting attachment 9433541 [details] to obsolete.

Attachment #9433541 - Attachment is obsolete: true

Comment on attachment 9433542 [details]
Bug 1927195 - Part 4: Prevent parsing using & await using syntax based on pref. r?arai!

Revision D226994 was moved to bug 1929045. Setting attachment 9433542 [details] to obsolete.

Attachment #9433542 - Attachment is obsolete: true

Comment on attachment 9434813 [details]
Bug 1927195 - Part 8: Add tests for when explicit resource management parsing is disabled. r?arai!

Revision D227666 was moved to bug 1929045. Setting attachment 9434813 [details] to obsolete.

Attachment #9434813 - Attachment is obsolete: true
Attachment #9433544 - Attachment description: Bug 1927195 - Part 6: Enable explicit resource management flag based on nightly flag. r?arai! → Bug 1927195 - Enable explicit resource build management flag based on nightly flag. r?arai!
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/a5cc817a5759 Enable explicit resource build management flag based on nightly flag. r=arai

https://hg.mozilla.org/mozilla-central/rev/a5cc817a5759

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Regressions: 1932110
Regressions: 1934366
Regressions: 1934367
Regressions: 1934425
Regressions: 1934211
Regressions: 1935283
Regressions: 1936757
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: