1927201 - PiP captions for site overrides using videojsWrapper.js don't render as expected when there's multiple span elements

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P1)

Description

[kernp25]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

1. Open https://www.arte.tv/fr/videos/116710-012-A/le-dessous-des-images/
2. Enable subtitles

Actual results:

Original text in player:
Les trois couleurs du drapeau américain.

Text in PiP player:
Les trois couleursdu drapeau américain.

Comment 1

[kernp25]

Attachment: Bug 1927201 - Use textContent instead of innerText in videojsWrapper.js. r?#pip-reviewers,kpatenio

Comment 2

[kpatenio]

Confirming from my own testing that the issue doesn't occur with macOS (tested using Sonoma 14.6.1), but does with windows 11, on arte.tv. Thanks for submitting a patch.

I'd normally consider this more of a bug, rather than an enhancement, since the captions don't appear as expected. We'll have to see how the changes affect other sites too, since the wrapper isn't just used for arte.tv. Changing the ticket type accordingly. Also setting to P1 since the patch is up and ready for review.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18af0608f7f1
Use textContent instead of innerText in videojsWrapper.js. r=kpatenio,pip-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/18af0608f7f1

Comment 5

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build using Win 10 and following the STR from comment 0.
Verified as fixed on Firefox Nightly 135.0a1 (20241219095656) and Firefox 134.0b10 (20241213091550) across the following platforms: Win 10, Ubuntu 22 and macOS 11. The text in PiP player at 01:09: Les trois couleurs du drapeau américain is correctly written .