1927216 - moz-page-nav buttons/links should be scrollable when they are longer than the window

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Mark Striemer [:mstriemer]]

If there is more content than can be shown in the moz-page-nav then the page buttons/links should scroll together

Comment 1

[Mark Striemer [:mstriemer]]

Acceptance Criteria:

• The page nav buttons/hr/links are grouped into a scrollable container
• The heading/search stay fixed when scrolling
• Story added with extra items so that it can scroll easily in Storybook

Comment 2

[Mark Kennedy [:mark]]

Attachment: Bug 1927216 - Make moz-page-nav buttons scrollable r=#recomp-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/682998c46e3f
Make moz-page-nav buttons scrollable r=reusable-components-reviewers,desktop-theme-reviewers,mstriemer,hjones

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9950044f8e21
Revert "Bug 1927216 - Make moz-page-nav buttons scrollable r=reusable-components-reviewers,desktop-theme-reviewers,mstriemer,hjones" for failures on browser_parsable_css.js.

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for failures on browser_parsable_css.js.

Push with failures

Failure log

Backout link

Comment 6

[Mark Kennedy [:mark]]

Taking a look at this now. Thanks!

Comment 7

[Mark Kennedy [:mark]]

The test (rightfully) detected that the --page-nav-margin-bottom CSS variable was no longer being used, so it's declaration also needed to be removed. Updated the patch.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72b3f8e98e95
Make moz-page-nav buttons scrollable r=reusable-components-reviewers,desktop-theme-reviewers,mstriemer,hjones

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/72b3f8e98e95

Comment 10

[Mark Kennedy [:mark]]

Hey Cristian, I see that this was reverted via https://phabricator.services.mozilla.com/rFIREFOXBETA6a7f5dfd9335e1fab5ac0644a28a8da8f817a0a4. Was there an issue with the patch there? Thanks for any information!

Comment 11

[Cristian Tuns]

Hi, I think that is when the revert merged to beta, but I also see that in the merge the updated version of the patch is also there: https://hg-edge.mozilla.org/releases/mozilla-beta/rev/72b3f8e98e95225afb252ffa1c49b0faab992a11. So this should be fixed in beta(140).
And that revert is the revert mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=1927216#c5 that got merged to beta.
Aryx can you please take a look at this, not sure why it appears like that in phabricator.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There was an issue during the central to beta merge. The log for one of the modified files shows the expected history: the change landed, got backed out ("reverted") and relanded with the issue fixed. I have been told there is no work planned to modify those Phabricator revisions again.