1927348 - Use Intl.DateTimeFormat in cZ's strftime function

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

At the moment chatZilla has it's only localisations for weekdays, months and AM/PM. This can be avoided by making use of Intl.DateTimeFormat
At the same time:

• use JS String padStart method for padNumber function
• use the definitions from metacpan https://github.com/houseabsolute/DateTime-Locale for %c, %x and %X for the locales

Comment 1

[Ian Neal]

Attachment: 1927348-irc-strftime-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: potential inconsistency of localisation between cZ and other parts of SM
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: 12 strings removed, 3 strings added

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1927348-irc-strftime-addendum-25321.patch

I think if you use the user locale it will not honor the users prefs / OS regional settings. Maybe use undefined but not really important here. Maybe we should drop the whole pref and format dates like its done in the mail part.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9433548 [details] [diff] [review]
1927348-irc-strftime-25320.patch

lgtm r/a+
See addendum patch for further testing. Not important. Just lets get 2.53.20b1 out of the door.

Comment 4

[Ian Neal]

Comment on attachment 9440925 [details] [diff] [review]
1927348-irc-strftime-addendum-25321.patch

[Triage Comment]
I'd already consider this but was waiting on review comments... r/a=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bcde333a18eb
Use Intl.DateTimeFormat in cZ's strftime function. r=frg