Closed
Bug 1927376
Opened 3 months ago
Closed 2 months ago
Use more Services in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
5.92 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
Make use of Services in a few more places across chatZilla.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9433564 -
Flags: review?(frgrahl)
Attachment #9433564 -
Flags: approval-comm-release?
|
||
Updated•2 months ago
|
|
|
||
Comment 2•2 months ago
|
||
Comment on attachment 9433564 [details] [diff] [review]
1927376-irc-service-tidy-25320.patch
NIT:
- var pxSize = Services.prefs.getBranch(null)
-
.getIntPref("font.size.variable.x-western", 16);
I am pretty sure the getBranch(null) is not needed here. Maybe you can test if yes and add a fixup patch for later. Otherwise lgtm r/a+
Attachment #9433564 -
Flags: review?(frgrahl)
Attachment #9433564 -
Flags: review+
Attachment #9433564 -
Flags: approval-comm-release?
Attachment #9433564 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/ee8917bf9d3d
Use more Services in cZ. r=frg
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•