Closed Bug 1927377 Opened 3 months ago Closed 2 months ago

Tidy up some Components.* code in static.js in cZ

Categories

(SeaMonkey :: Chat, task)

Product:
SeaMonkey
Component:
Chat
Type:
task

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.20)

Attachments

(1 file, 1 obsolete file)

1927377-irc-cc-ci-static-v1_1-25320.patch
9.93 KB, patch
frg
: review+
frg
: approval-comm-release+
Details | Diff | Splinter Review

Make use of Cc, Ci and generateQI in static.js also remove some used const

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9433565 - Flags: review?(frgrahl)
Attachment #9433565 - Flags: approval-comm-release?

Fix missing import

Attachment #9433565 - Attachment is obsolete: true
Attachment #9433565 - Flags: review?(frgrahl)
Attachment #9433565 - Flags: approval-comm-release?
Attachment #9434554 - Flags: review?(frgrahl)
Attachment #9434554 - Flags: approval-comm-release?
status-seamonkey2.53: --- → affected
tracking-seamonkey2.53: --- → ?
Whiteboard: SM2.53.20

Comment on attachment 9434554 [details] [diff] [review]
1927377-irc-cc-ci-static-v1_1-25320.patch

lgtm r/a+

Attachment #9434554 - Flags: review?(frgrahl)
Attachment #9434554 - Flags: review+
Attachment #9434554 - Flags: approval-comm-release?
Attachment #9434554 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/1266d1cd7642
Tidy up some Components.* code in static.js in cZ. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: