1927443 - The user cannot use keyboard navigation to move foxus backwards to the Theme or the Text and layout buttons from Reader View mode

Status: VERIFIED FIXED

(Toolkit :: Reader Mode, defect)

Description

[Daniel Bodea [:danibodea]]

Note

• When in Reader View mode, the user cannot use keyboard navigation (SHIFT+TAB) to move focus upwards from the Read Aloud button to the Theme button, or to the Text and layout button from the Reader View mode.

Found in

• Beta v132.0 (RC)

Affected versions

• Beta v132.0 (RC)
• Nightly v133.0a1

Tested platforms

• Affected platforms: Windows 10, MacOS 11.
• Unaffected platforms: ?

Steps to reproduce

1. Load a webpage that supports Reader View mode:
   ex. https://en.wikipedia.org/wiki/Main_Page
2. Enable Reader View mode.
3. Using keyboard navigation navigate forward beyond the Theme button (using TAB key).
4. Using keyboard navigation navigate to the Theme button, or the Text and layout button (using SHIFT+TAB hotkey).

Expected result

• The user is able to move focus on the Theme button and the Text and layout button.

Actual result

• The user is NOT able to move focus on the Theme button and the Text and layout button.

Regression range

• Potentially regressed by: bug 1909885
  Bug 1909885 - Add shift tab listeners for reader mode narrator, theme menu, and text menu. r=Gijs
  Remove redundant lines, fix test to correctly check focus in text layout menu
  Differential Revision: https://phabricator.services.mozilla.com/D220969

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sandy.chu.40, since you are the author of the regressor, bug 1909885, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1927443 - fix tab navigation around narrate control, r?eeejay,#reader-mode-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/400f611af7b9
fix tab navigation around narrate control, r=eeejay

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/400f611af7b9

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[:Gijs (he/him)]

Attachment: Bug 1927443 - fix tab navigation around narrate control, r?eeejay,#reader-mode-reviewers

Original Revision: https://phabricator.services.mozilla.com/D227097

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: broken focus behaviour in reader mode
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: small patch, has automated test, early beta cycle
• String changes made/needed: no
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6bc468540055

Comment 9

[Daniel Bodea [:danibodea]]

It would appear that the current issue was fixed, but another regression is uncovered: bug 1928433.
@Gijs: Can you check it out?

Comment 10

[:Gijs (he/him)]

(In reply to Daniel Bodea [:danibodea] from comment #9)

It would appear that the current issue was fixed, but another regression is uncovered: bug 1928433.
@Gijs: Can you check it out?

Thanks, I will check in that bug (where bugbot also gave me a needinfo. :-) )

Comment 11

[Daniel Bodea [:danibodea]]

I can confirm this fix in Nightly v134.0a1 and Beta v133.0b2 in Windows 10, Unbuntu 22 and MacOS 11.
Considering the regression mentioned in comment 9, I will close this report. Thank you.