1927466 - AV1 AVX2 encoder code is broken

Status: UNCONFIRMED

(Core :: Audio/Video: Web Codecs, defect)

Description

[Elle Solomina (she/her)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Actual results:

13:19.00 C:/mozilla-source/mozilla-unified/third_party/aom/av1/encoder/x86/av1_fwd_txfm2d_avx2.c(2052,25): warning: result of comparison of 4 < 2-bit unsigned value is always false [-Wtautological-value-range-compare]
13:19.00 2052 | for (int j = 0; j < AOMMIN(4, height_div16); ++j) {
13:19.00 | ^~~~~~~~~~~~~~~~~~~~~~~
13:19.01 C:/mozilla-source/mozilla-unified/third_party/aom\aom_dsp/aom_dsp_common.h(26,28): note: expanded from macro 'AOMMIN'
13:19.01 26 | #define AOMMIN(x, y) (((x) < (y)) ? (x) : (y))
13:19.01 | ~~~ ^ ~~~
13:21.49 dom/push

Comment 1

[Elle Solomina (she/her)]

https://searchfox.org/mozilla-central/source/third_party/aom/av1/encoder/x86/av1_fwd_txfm2d_avx2.c#2052

Comment 2

[Elle Solomina (she/her)]

There is a probably live fork of this library https://github.com/Clybius/aom-av1-lavish