Open Bug 1927534 Opened 5 days ago Updated 4 days ago

Update xsimd to new version e384105a2a3809c319f0740e2ebf6166da895fcb from 2024-10-16 06:11:04

Categories

(Core :: Performance, enhancement)

Product:
Core
Component:
Performance
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox134 --- affected

People

(Reporter: update-bot, Assigned: padenot, NeedInfo)

Details

(Whiteboard: [3pl-filed][task_id: Xsw7k1MUSc2Y6qGoHG-l1A])

Attachments

(1 file)

Bug 1927534 - Update xsimd to e384105a2a3809c319f0740e2ebf6166da895fcb
48 bytes, text/x-phabricator-request
Details | Review

This update covers 9 commits. Here are the overall diff statistics, and then the commit information.

third_party/xsimd/include/xsimd/arch/generic/xsimd_generic_memory.hpp | 26 +++
third_party/xsimd/include/xsimd/arch/xsimd_avx.hpp | 81 ++++++++++
third_party/xsimd/include/xsimd/arch/xsimd_neon.hpp | 64 +++++++
third_party/xsimd/include/xsimd/arch/xsimd_neon64.hpp | 31 +++
third_party/xsimd/include/xsimd/arch/xsimd_sse2.hpp | 44 +++++
third_party/xsimd/include/xsimd/arch/xsimd_wasm.hpp | 36 ++++
third_party/xsimd/include/xsimd/types/xsimd_api.hpp | 30 ++-
third_party/xsimd/include/xsimd/types/xsimd_rvv_register.hpp | 81 +++++++++-
third_party/xsimd/moz.yaml | 4 +-
9 files changed, 388 insertions(+), 9 deletions(-)

e384105a2a3809c319f0740e2ebf6166da895fcb by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/e384105a2a3809c319f0740e2ebf6166da895fcb
Authored: 2024-10-15 21:04:45 +0200
Committed: 2024-10-16 06:11:04 +0000

WIP

Files Modified:

  • include/xsimd/types/xsimd_rvv_register.hpp

5642b7c89b5f8bc82847372ab6d3a201223ab4b2 by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/5642b7c89b5f8bc82847372ab6d3a201223ab4b2
Authored: 2024-10-15 20:46:53 +0200
Committed: 2024-10-16 06:11:04 +0000

Setup CI for Risc V testing with clang 17 and 18

Files Modified:

  • .github/workflows/cross-rvv.yml

d50061f78e0ee8d83774c0541a2f3f85b88a461f by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/d50061f78e0ee8d83774c0541a2f3f85b88a461f
Authored: 2024-10-15 15:58:07 +0200
Committed: 2024-10-16 06:11:04 +0000

Fix clang-17 miscompilation of __riscv_vreinterpret_u8m8

Fix #1059

Files Modified:

  • include/xsimd/types/xsimd_rvv_register.hpp

e885287c063db89b619fa3fbc22d8c529f11e713 by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/e885287c063db89b619fa3fbc22d8c529f11e713
Authored: 2024-10-15 08:27:18 +0200
Committed: 2024-10-15 12:44:50 +0000

Report status (failure or success) when downloading doctest .h

While we're at it, fix option name typo XSIMD_DOWNLOAD_DOCTEST -> DOWNLOAD_DOCTEST

Fix #1056

Files Modified:

  • test/CMakeLists.txt

e4e871c79dcb5edf1fb3f39f0eea27e656ea99ad by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/e4e871c79dcb5edf1fb3f39f0eea27e656ea99ad
Authored: 2024-10-14 17:40:17 +0200
Committed: 2024-10-14 20:10:15 +0000

Validate CMake integration

Closes #538

Files Added:

  • .github/cmake-test/CMakeLists.txt
  • .github/cmake-test/main.cpp
  • .github/workflows/cmake.yml

49be336f37e5916d2b40b6fbf1238f48bf71e02b by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/49be336f37e5916d2b40b6fbf1238f48bf71e02b
Authored: 2024-10-11 22:18:03 +0200
Committed: 2024-10-12 05:58:34 +0000

Add support for xsimd::transpose

Support 64 bit registers for avx, neon, sse and wasm

Files Modified:

  • include/xsimd/arch/xsimd_avx.hpp
  • include/xsimd/arch/xsimd_neon.hpp
  • include/xsimd/arch/xsimd_neon64.hpp
  • include/xsimd/arch/xsimd_sse2.hpp
  • include/xsimd/arch/xsimd_wasm.hpp

9906e7177df8b6c1e79cd9b5b6ed1e5223b1d4bf by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/9906e7177df8b6c1e79cd9b5b6ed1e5223b1d4bf
Authored: 2024-10-05 19:41:24 +0200
Committed: 2024-10-12 05:58:34 +0000

Add support for xsimd::transpose

Currently only specialized 32bits types on sse, avx, neon and wasm. The
other implementations fallback to sequential generic implementation.

Fix #107 (6 years old!)

Files Modified:

  • docs/source/api/data_transfer.rst
  • include/xsimd/arch/generic/xsimd_generic_memory.hpp
  • include/xsimd/arch/xsimd_avx.hpp
  • include/xsimd/arch/xsimd_neon.hpp
  • include/xsimd/arch/xsimd_neon64.hpp
  • include/xsimd/arch/xsimd_sse2.hpp
  • include/xsimd/arch/xsimd_wasm.hpp
  • include/xsimd/types/xsimd_api.hpp
  • test/test_shuffle.cpp

3747986fc59032d1cfbadcf55236c475f26451c3 by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/3747986fc59032d1cfbadcf55236c475f26451c3
Authored: 2024-10-05 09:04:49 +0200
Committed: 2024-10-05 08:09:13 +0000

Fix Documentation generation

Mostly ill-named groups, missing predefined macro and some group
splitting for select operation.

Fix #1029

Files Modified:

  • docs/Doxyfile
  • docs/source/api/batch_manip.rst
  • docs/source/api/xsimd_batch_complex.rst
  • include/xsimd/types/xsimd_api.hpp

c4dd6bdc61c7f5a9c4335a009bb0839fe2d97a18 by serge-sans-paille <serge.guelton@telecom-bretagne.eu>

https://github.com/QuantStack/xsimd/commit/c4dd6bdc61c7f5a9c4335a009bb0839fe2d97a18
Authored: 2024-10-05 09:21:27 +0200
Committed: 2024-10-05 08:09:13 +0000

Update Github CI micromamba integration

Files Modified:

  • .github/workflows/emulated.yml
  • .github/workflows/linux.yml

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=ec591badc88df8884c5372e601f9937a3a72d7dc

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

  • test-android-em-7.0-x86_64-qr/debug-geckoview-junit-nofis-ship - 3 of 4 failed on the same (retriggered) task (failed: WmLaemCCRa2X-PoG3yyyvg, BECI6JXnS-qBIM7mgVMcng, bahF1-uGQP2YIGHan2G9qQ)
  • test-macosx1015-64-qr/opt-gtest-1proc - 1 of 4 failed on the same (retriggered) task (failed: FsJP6KGBRWujtGCBhFyVjw)

Needs Investigation (Possible Intermittents):

  • browser/components/extensions/test/browser/browser_ext_popup_select_in_oopif.js

    • 2 of 4 failed on the same (retriggered) task
      - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-7 (dcSiLbEYRImV5dc5QUdnpg)
      - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-7 (OQcl9uNoSuWb7Pp5ALdvgQ)

  • html/semantics/popovers/popover-events.html

    • 1 of 4 failed on the same (retriggered) task
      - test-linux1804-64-qr/opt-web-platform-tests-4 (TEoXnZBDTCuY66UR3WRKfA)

  • toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_force_enrollment.js

    • 2 of 4 failed on the same (retriggered) task
      - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-7 (dcSiLbEYRImV5dc5QUdnpg)
      - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-7 (OQcl9uNoSuWb7Pp5ALdvgQ)

Known Issues:

  • browser/base/content/test/performance/browser_startup.js
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-7 (BoqhXMWiT9eV4UboPpYXCg)

  • browser/components/firefoxview/tests/browser/browser_opentabs_recency.js
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-8 (bAxcK39pQxqPvytL2gCJDw)

  • browser/components/sidebar/tests/browser/browser_vertical_tabs_stacking_context.js
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-4 (T1UhLjJ1R1GgWEdVaRP1EA)

  • browser/components/urlbar/tests/browser/browser_urlbar_telemetry_persisted.js
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-6 (TIVvBpXETk-DVsoTm0BMGQ)

  • dom/manifest/test/browser_ManifestFinder_browserHasManifestLink.js
    - test-windows11-64-2009-qr/opt-mochitest-browser-chrome-spi-nw-4 (H59wuMdNSCyd2c7AvMXGWw)

  • html/semantics/popovers/popover-hover-hide-toggle.tentative.html
    - test-linux1804-64-qr/opt-web-platform-tests-4 (TEoXnZBDTCuY66UR3WRKfA)

  • browser/components/extensions/test/browser/browser.toml
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-7 (dcSiLbEYRImV5dc5QUdnpg)
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-7 (OQcl9uNoSuWb7Pp5ALdvgQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor third_party/xsimd/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Assignee: nobody → padenot
Flags: needinfo?(padenot)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: