1927541 - Menu bug 1910814 added an unnecessary dependency on proprietary Google library (for googleg_standard_color_18)

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Tad]

Steps to reproduce

1. compile Fenix without proprietary library

Expected behavior

it compiles

Actual behavior

it doesn't

> Task :app:compileFenixReleaseKotlin
e: file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:213:40 Unresolved reference: googleg_standard_color_18
file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:213:40: error: Unresolved reference: googleg_standard_color_18
file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:213:40: error: Unresolved reference: googleg_standard_color_18
e: file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:261:40 Unresolved reference: googleg_standard_color_18
file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:261:40: error: Unresolved reference: googleg_standard_color_18
file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/ExtensionsSubmenu.kt:261:40: error: Unresolved reference: googleg_standard_color_18
e: file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuItem.kt:265:58 Unresolved reference: googleg_standard_color_18
file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuItem.kt:265:58: error: Unresolved reference: googleg_standard_color_18
file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/menu/compose/MenuItem.kt:265:58: error: Unresolved reference: googleg_standard_color_18
e: file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/compose/list/ListItem.kt:980:58 Unresolved reference: googleg_standard_color_18
file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/compose/list/ListItem.kt:980:58: error: Unresolved reference: googleg_standard_color_18
file:///mnt/fdroid/fdroiddata/build/srclib/MozFennec/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/compose/list/ListItem.kt:980:58: error: Unresolved reference: googleg_standard_color_18

Any additional information?

please stop spuriously adding unnecessary dependencies on proprietary google libraries

most of these are likely just being autoimported or tab completed by developers

having to constantly patch these out to ship updates on time is frustrating

Comment 1

[Chris Peterson [:cpeterson]]

@ Tad, thanks for reporting this library issue.

@ Gabriel, which Google library did we import in bug 1910814 to use googleg_standard_color_18? What color is googleg_standard_color_18? Can we instead use a color from the Acorn design system?

Comment 2

[Iorga Gabriel]

I will make a fix . I will change the color.

Comment 3

[Iorga Gabriel]

Attachment: Bug 1927541 - Remove dependency on proprietary Google library (for googleg_standard_color_18).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87572a2f52e3
Remove dependency on proprietary Google library (for googleg_standard_color_18). r=android-reviewers,avirvara

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/87572a2f52e3

Comment 6

[Tad]

thank you everyone!

Comment 7

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1910814

Comment 8

[Chris Peterson [:cpeterson]]

Tad, this fix landed in Fenix Nightly 134, but the regression (bug 1910814) landed in Fenix 132. Would backporting this fix to Beta 133 help with your F-Droid builds? Or can you patch out googleg_standard_color_18 until this fix ships in Fenix 134 (2025-01-07)? Which Fenix version are you building? The new menu that uses this googleg_standard_color_18 code is not enabled in Beta 133 or Fenix 132.

Comment 9

[Tad]

I already hacky patched it out and shipped 132 a day early :)

but thank you again for a proper fix for when it ships in 134!

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.