1927546 - Connections to port 4160 are erroneously blocked by the "bad port list" (should be 4190)

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Pawel]

Actual results:

The patch from bug https://bugzilla.mozilla.org/show_bug.cgi?id=1889059 adds port 4160 to the gBadPortList array. This is wrong, the port number should be 4190, as mentioned in the title of the aforementioned bug report.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:jesup, since you are the author of the regressor, bug 1889059, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1927546: Fix sieve port number r=#necko-reviewers!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1889059

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4472f9cb7110
Fix sieve port number r=necko-reviewers,valentin

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4472f9cb7110

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jesup, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 9435277 [details]
Bug 1927546: Fix sieve port number r=#necko-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: super-low-risk fix to recent checkin
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): About as low a risk as is possible
• String changes made/needed: none
• Is Android affected?: Yes

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9435277 [details]
Bug 1927546: Fix sieve port number r=#necko-reviewers!

Approved for 133.0b9

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b3779cedfdf8

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9435277 [details]
Bug 1927546: Fix sieve port number r=#necko-reviewers!

Approved for 128.5esr.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/5fa9e628de10