1927549 - Refactor `nsFrameSelection::CreateRangeExtendedToSomewhere()` to remove dependency of `Selection`

Status: RESOLVED FIXED

(Core :: DOM: Selection, task)

Description

[Jan Jaeschke [:jjaschke]]

nsFrameSelection::CreateRangeExtendedToSomewhere() currently expects the range to be extended to be the first range of the normal Selection.
However, extending a range by a word comes in handy when implementing an algorithm to create a text fragment from a range (Bug 1876524), in which no Selection is present (instead only nsRanges), among other use cases.

This bug moves the logic to extend a range by an amount into SelectionMovementUtils and removes the dependency of Selection.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: WIP: Bug 1927549, part 2: Moved logic of `nsFrameSelection::PeekOffsetForCaretMove()` into helper methods. r=masayuki!

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1927549, part 1: Introduce enum `ExtendSelection` in `nsFrameSelection`. r=masayuki!

Comment 3

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1927549, part 2: Moved logic of `nsFrameSelection::PeekOffsetForCaretMove()` into helper methods. r=masayuki!

Comment 4

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1927549, part 3: Introduced `SelectionMovementUtils::MoveRangeBoundaryToSomewhere()`. r=masayuki!

This new helper function can move a range boundary by aAmount without requiring to be in a selection.

Comment 5

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1927549, part 4: Renamed `aContinueSelection` to `aExtendSelection` to align with the enum name. r=masayuki!

Comment 6

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1927549, part 5: Moved content of `nsFrameSelection::PeekOffsetForCaretMove()` into `nsFrameSelection::MoveCaret()`. r=masayuki!

The logic of this method was moved into helper methods in part 2 of this patchset.
Now, there was only one caller left.
So, we can easily move the code into the one call site and get rid of the method.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac1cca025807
part 1: Introduce enum `ExtendSelection` in `nsFrameSelection`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/2f6e8e5ac5dd
part 2: Moved logic of `nsFrameSelection::PeekOffsetForCaretMove()` into helper methods. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/f0ba0a69319a
part 3: Introduced `SelectionMovementUtils::MoveRangeBoundaryToSomewhere()`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/dc7e27f6058a
part 4: Renamed `aContinueSelection` to `aExtendSelection` to align with the enum name. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/27cbe2030881
part 5: Moved content of `nsFrameSelection::PeekOffsetForCaretMove()` into `nsFrameSelection::MoveCaret()`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/89ffb15c23a7
apply code formatting via Lando

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ac1cca025807
https://hg.mozilla.org/mozilla-central/rev/2f6e8e5ac5dd
https://hg.mozilla.org/mozilla-central/rev/f0ba0a69319a
https://hg.mozilla.org/mozilla-central/rev/dc7e27f6058a
https://hg.mozilla.org/mozilla-central/rev/27cbe2030881
https://hg.mozilla.org/mozilla-central/rev/89ffb15c23a7