1927582 - Switch to using listbox instead of tree for cZ chat window

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

It seems to be very complicated to use a tree for a list of users when a listbox is designed to have lists in.
Each channel stores its list of users in an array which it then populates the listbox with.
Listboxes seem to be a lot easier to select and manipulate than trees.

Comment 1

[Ian Neal]

Attachment: 1927582-irc-chat-window-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): medium
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: 1927582-irc-chat-window-v1_1-25320.patch

Adjust css for listcell icon/label

Comment 3

[Ian Neal]

Attachment: 1927582-irc-chat-window-v1_2-25320.patch

Fix clearing listbox when it's the one for another channel

Comment 4

[Ian Neal]

Attachment: 1927582-irc-chat-window-v1_3-25320.patch

Changes since last patch:

• As there is only one listbox, attach to client rather than each channel
• User client.currentObject to determine if we need to update the channel view rather than using collectionKey / parentKey attributes on the listbox
• Add fix for own away status

Comment 5

[Ian Neal]

Attachment: 1927582-irc-chat-window-v1_3a-25320.patch

Fixes issue with errors appearing in stdout / console when reconnecting to a server when you have away status.

Comment 6

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9436629 [details] [diff] [review]
1927582-irc-chat-window-v1_3a-25320.patch

LGTM r/a+

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d55a0927e5e3
Switch to using listbox instead of tree for cZ chat window. r=frg

Comment 8

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/cf2fbbb69938d4647973bfb9f4465811b087587e
Switch to using listbox instead of tree for cZ chat window. r=frg a=frg