1927637 - Ignore punctuation when matching weather suggestions

Status: RESOLVED FIXED

(Application Services :: Suggest, task, P1)

Description

[Drew Willcoxon :adw]

We should ignore punctuation when matching weather suggestions, e.g., the comma in: "weather waterloo, ia"

Comment 1

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 1927637 - Ignore punctuation when matching weather suggestions (#6442)

Comment 2

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 1927637 - Ignore punctuation when matching weather suggestions (backport #6442) (#6447)

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 9434310 [details] [review]
[mozilla/application-services] Bug 1927637 - Ignore punctuation when matching weather suggestions (backport #6442) (#6447)

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This is a small fix to weather suggestions on desktop, which we want for 133
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects weather suggestions on desktop, which are preffed off by default
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Donal Meehan [:dmeehan]]

Comment on attachment 9434310 [details] [review]
[mozilla/application-services] Bug 1927637 - Ignore punctuation when matching weather suggestions (backport #6442) (#6447)

Approved for AS 133.0.1

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9434310 [details] [review]
[mozilla/application-services] Bug 1927637 - Ignore punctuation when matching weather suggestions (backport #6442) (#6447)

Changing uplift approval to Beta.
Fx133 Application Services is in Beta until Fx133 hits release.