1927699 - Overriding line-height doesn't reset the value properly.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[robin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36

Steps to reproduce:

The following codepen shows that when you set a global line-height in a * selector, and then override it for a specific selector, it still uses the old value.

If you compare the codepen between Chrome and Firefox, you'll notice that in Chrome the lines are really close together (at a line-height of 1), but in Firefox they're really far apart (the old value 5).

https://codepen.io/Robin-Mosterd/pen/eYqMzwK

Actual results:

The line-height was at the wrong, old value.

Expected results:

The line-height should've been overwritten to 1.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:jwatt, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Jonathan Watt [:jwatt]]

Weird the cascade would fail for this specific property.

Comment 3

[David Shin[:dshin]]

Attachment: User submitted testcase

Oh, <br> has line-height: 5 which is affecting the layout.

Comment 4

[David Shin[:dshin]]

I think we need to take parent's font metric (setting font-size on br has a similar issue) and line height here.

Comment 5

[Seva Alipov]

Attachment: Bug 1927699: Prevent <br> from having its own block size via its own line-height or font properties. r=#style

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c240063f8024
https://hg.mozilla.org/integration/autoland/rev/5571a3bdc2ad
Prevent <br> from having its own block size via its own line-height or font properties. r=firefox-style-system-reviewers,layout-reviewers,dshin

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60517 for changes under testing/web-platform/tests

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5571a3bdc2ad

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot