1927716 - [Design System API Migration] Update Dropdown to use DropdownMenu instead of ContexualMenu

Status: VERIFIED FIXED

(Firefox for Android :: Design System and Theming, task, P2)

Description

[Rahul Sainani [:rsainani]]

When Bug 1834654 lands, consider migrating to the new API for menu (DropdownMenu) for Dropdown file (which maybe should be called TextFieldWithDropdown). The API is now concise and supports all the usecases defined in the design system.

Note: There are other usages that can be used as examples. For easy migration, use the IntelliJ contextual actions after removing the deprecation warning suppression on the callsite.

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Bug 1927716 - [Design System API Migration] Update Dropdown and its usages to use DropdownMenu instead of ContextualMenu

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee5181a4dd6d
[Design System API Migration] Update Dropdown and its usages to use DropdownMenu instead of ContextualMenu r=android-reviewers,ohall,007

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ee5181a4dd6d

Comment 4

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Can QA please verify that the dropdowns in Translations Bottom Sheet are behaving the same as they were in Fx135 / 134?

In particular, here is the STR and things to focus on:

1. Go to https://en.wikipedia.org/wiki/Canada.
2. Click the 3 dot menu
3. Click on Tools (if menu redesign is enabled)
4. Click on Translate page...
5. Click on both the Translate from and Translate to dropdowns
   i. Check that the padding for the dropdown items is correct. This should be the same regardless of whether items are selected or not.
6. Additionally, check that the touch area fills the entire row when there are no items selected and when there is an item selected.
   ii. Check that the positioning of the dropdown is correct in both landscape and vertical orientations.
   iii. Check that the currently checked item is correct (matches what is shown before you click on the dropdown)
   iv. Check that if the placeholder is currently being shown, no item is selected in the dropdown items
   v. Check that at most 1 dropdown item is selected
   vi. Opening to the selected option and ensuring this was working correctly in TalkBack and that TalkBack works properly in general.

Comment 5

[Lorand Janos]

Hi,
Verified as fixed on the latest Nightly build (136.0a1 from 2025-01-30).
All the above steps are verified and are correct.
I found a small issue with talkback, announcing "Double tap to toggle" an already selected language which then does no change, but I'll file a separate ticket Here it is.
Device used: Google Pixel 9 Pro XL (Android 15).
Marking the ticket as verified on 136.