1927721 - Force a shutdown of Firefox if the Websocket port cannot be aquired after 5s

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

In Marionette, we use a PollPromise to retry the creation of the ServerSocket for 5 seconds to avoid immediate failure if another Firefox process is shutting down and still has the same socket in use. If we can't acquire the requested port, we force a shutdown of Firefox to prevent lingering processes.

Interestingly, we don't apply the same logic for the Remote Agent and its WebSocket port. We should probably introduce similar behavior to prevent Firefox instances from lingering if they can’t be controlled or shut down properly by the client.

This may be the cause of the issue seen with Puppeteer: https://github.com/puppeteer/puppeteer/pull/13245.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Attachment: Bug 1927721 - [remote] Add retry mechanism to the Remote Agent for binding the HTTP server.

This patch introduces a retry mechanism for binding the
Remote Agent's HTTP server to a port, improving resilience
in scenarios where the port might initially be unavailable.

If all attempts fail, the application is forced to quit.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

We are in a soft freeze phase. So I'll wait with the landing of the patch until Monday afternoon.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9114d64794ba
[remote] Add retry mechanism to the Remote Agent for binding the HTTP server. r=webdriver-reviewers,jdescottes

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9114d64794ba