1927764 - Text-Fragments: Use MOZ_LOG_FMT for log messages

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Jan Jaeschke [:jjaschke]]

Bug 1717448 introduced std::fmt into our code base. Using it for log messages should make the log messages less verbose and ugly.

Comment 1

[Jan Jaeschke [:jjaschke]]

The Text Fragments code (especially the FragmentDirective class and the TextDirectiveUtil helper) make heavy use of logging.

This is currently done using a specialization of the MOZ_LOG macro.

Bug 1717448 introduced logging using std::format (documentation, example patch).

The specialized TEXT_FRAGMENT_LOG macros should be adapted to make use of MOZ_LOG_FMT, as well as all usages.

Comment 2

[Roland Kossel]

Attachment: Bug 1927764, part 1: change logger macros of TextFragment to use MOZ_LOG_FMT. r=jjaschke

Comment 3

[Roland Kossel]

Attachment: Bug 1927764, part 2: rename `sFragmentDirectiveLog` to `gFragmentDirectiveLog`. r=jjaschke

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0289dfc64fce
part 1: change logger macros of TextFragment to use MOZ_LOG_FMT. r=jjaschke
https://hg.mozilla.org/integration/autoland/rev/a62ffaa65df2
part 2: rename `sFragmentDirectiveLog` to `gFragmentDirectiveLog`. r=jjaschke

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0289dfc64fce
https://hg.mozilla.org/mozilla-central/rev/a62ffaa65df2