1927778 - [toolbar redesign] Focus toolbar's right margin

Status: VERIFIED FIXED

(Focus :: General, defect, P1)

Description

[Mira Lobontiu (Android QA)]

Attachment: az_recorder_20241029_155724_edited.mp4

Steps to reproduce

1. Download Focus Nightly from here: https://archive.mozilla.org/pub/focus/nightly/2024/
2. Open it, and skip the onboarding.
3. Tap on the search field, and observe the right margin of the toolbar while the keyboard is triggerred.

Expected behavior

The search field does not change.

Actual behavior

The right margin of the search field is moving - please see the video attached.

Device information

• Focus version: Nightly 134.0a1 from 10/29
• Android devices: Vivo v23 (Android 13), Google Pixel 6 (Android 15), Samsung Galaxy S24 (Android 14)

Comment 1

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1927778 - Revert initial fix for toolbar margins.

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1927778 - Adjust margins for display toolbar.

Depends on D227243

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04a813a50064
Revert initial fix for toolbar margins. r=android-reviewers,jonalmeida
https://hg.mozilla.org/integration/autoland/rev/f2378322889e
Adjust margins for display toolbar. r=android-reviewers,jonalmeida

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/04a813a50064
https://hg.mozilla.org/mozilla-central/rev/f2378322889e

Comment 5

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Focus Nightly 134.0a1 from 10/31 with Google Pixel 6 (Android 15), and OnePlus 5T (Android 10).

Comment 6

[Mihai Adrian Carare [:mcarare]]

Comment on attachment 9434173 [details]
Bug 1927778 - Adjust margins for display toolbar.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Focus right margin is variable resulting in bad UX.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Tap on the URL search fieldon home screen, and observe the right margin of the toolbar while the keyboard is triggerred.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is not risky since it only modifies UI.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9434032 [details]
Bug 1927778 - Revert initial fix for toolbar margins.

Approved for 133.0b6

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9434173 [details]
Bug 1927778 - Adjust margins for display toolbar.

Approved for 133.0b6

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c46036378a84
https://hg.mozilla.org/releases/mozilla-beta/rev/81993c41914a

Comment 10

[Mira Lobontiu (Android QA)]

Verified as fixed on the Beta 133.0b6 Focus build, with a Samsung Galaxy Tab S9 Ultra (Android 14), and a Google Pixel 6 (Android 15).