1927797 - Certificate Compression for QUIC

Status: RESOLVED FIXED

(NSS :: Libraries, task, P2)

Description

[Dexter Gerig]

Steps to reproduce:

Run Firefox 132 and attempt to make a connection to any site that supports QUIC.

Actual results:

A TLS ClientHello is sent without a compress_certificate extension leading to the server sending an uncompressed certificate for the QUIC connection.

Expected results:

The compress_certificate extension is sent and a compressed certificate is allowed to be used.

Comment 1

[Dexter Gerig]

Filing this as a defect because as far as I can tell the original certificate compression bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1548723) seems to indicate that QUIC was intended to work with certificate compression "... most certificate chains are cut in size by enough to matter. Especially for QUIC."

I couldn't find anything in the code or any other bug reports indicating that this intent had changed to not have it work with QUIC so I am putting this more in the bug category.

Comment 2

[Lars Eggert [:lars]]

This is something we're currently not doing, and we should. The neqo_glue code should hook in the same functions we use for TCP/TLS.

See https://github.com/mozilla/neqo/issues/2213

Comment 3

[Anna Weine]

Attachment: WIP: Bug 1927797 - Example exposing zlib in neqo_glue

Comment 4

[Anna Weine]

Attachment: Bug 1927797 - Enable zlib in neqo_glue

Comment 5

[Anna Weine]

Attachment: WIP: Bug 1927797 - Enable zstd in neqo_glue

Comment 6

[Anna Weine]

Attachment: WIP: Bug 1927797 - Enable brotli in neqo_glue

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b7fb637f7a0d
https://hg.mozilla.org/integration/autoland/rev/0eab70f2e6d8
Enable zlib in neqo_glue r=necko-reviewers,kershaw,mxinden

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0eab70f2e6d8

Comment 9

[Takanori MATSUURA]

Reopened for unpublished patches.

Comment 10

[Max Inden]

I accidentally added a dependency to Bug 1979279 here. I don't think this Bug needs to be reopened.

Comment 11

[Anna Weine]

Attachment: Bug 1927797 - Enable zstd in neqo_glue using c zstd implementation

Comment 12

[Anna Weine]

Attachment: Bug 1927797 - Enable brotli in neqo_glue

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0cfb08009948
https://hg.mozilla.org/integration/autoland/rev/e0e6fc39ba72
Enable zstd in neqo_glue using c zstd implementation r=necko-reviewers,jesup,keeler
https://github.com/mozilla-firefox/firefox/commit/bc7e1c135a52
https://hg.mozilla.org/integration/autoland/rev/ab39f564b2e0
Enable brotli in neqo_glue r=necko-reviewers,jesup,keeler

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cae0d3cf60a5
https://hg.mozilla.org/integration/autoland/rev/42d31161aaa1
Revert "Bug 1927797 - Enable brotli in neqo_glue r=necko-reviewers,jesup,keeler" for causing build bustages

Comment 15

[[e-mail]]

Backed out for causing build bustages

- Backout link
- Push with failures
- Failure log

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a50c89cb6bf4
https://hg.mozilla.org/integration/autoland/rev/7925b8e5ef36
Enable zstd in neqo_glue using c zstd implementation r=necko-reviewers,jesup,keeler

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7925b8e5ef36

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/82a36439ae3e
https://hg.mozilla.org/integration/autoland/rev/992c0c5e28b7
Enable brotli in neqo_glue r=necko-reviewers,jesup,keeler

Comment 19

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/992c0c5e28b7