1927927 - Moving a tab to a group should activate the group's window

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Amy Lee [:amylee] UX]

Steps to reproduce [can add screenshots or video recordings for reference]:

1. Open 1 window (window 1) and create a tab group
2. Open a second window (window 2) and open a new tab
3. Move the new tab to the group in window 1 via right click and "add tab to group"

Expected behavior [What should have happened?]:
window 1 becomes the active window and tab inside group is in focus

Actual behavior [What actually happened?]:

Tab disappears from window 2 (no feedback of where it went to)

Comment 1

[Stephen Thompson [:sthompson]]

:dwalker Your patch https://phabricator.services.mozilla.com/D228278 would address this, right?

Comment 2

[DJ (:dwalker)]

(In reply to Stephen Thompson [:sthompson] from comment #1)

:dwalker Your patch https://phabricator.services.mozilla.com/D228278 would address this, right?

No, the window focusing behavior in that patch is for when a tab is restored to a group from history. I think that behavior will be removed anyway; restoreTab isn't the right place for it and there are other cases (like this one) that make me think we should address this differently

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1927927 - Make moving a tab to a group via the tab context menu activate the group's window. r=dwalker,jswinarton

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5d32ff45ea3
Make moving a tab to a group via the tab context menu activate the group's window. r=dwalker,tabbrowser-reviewers

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e5d32ff45ea3

Comment 6

[Negritas Sergiu, Desktop QA]

Hello! I have managed to reproduce the issue with firefox 134.0a1(2024-10-29) on Ubuntu 22.04.
I can confirm that the issue is fixed with firefox 136.0b3 on Ubuntu 22.04, MacOS 15.2 and Windows 10.

I will update the flags and the status of this issue.

Have a nice day!