1928287 - Don't ping Merino for geolocation too often

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

We discussed caching the Merino geolocation response in https://phabricator.services.mozilla.com/D226858 (bug 1927010), and on second thought I think that's worth doing. It doesn't need to be cached for long, just so we don't ping Merino for it on each keystroke.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1928287 - Cache Merino geolocation for a brief period so we don't ping it on every keystroke.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fdcdccf7fcd
Cache Merino geolocation for a brief period so we don't ping it on every keystroke. r=daisuke

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9fdcdccf7fcd

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9434404 [details]
Bug 1928287 - Cache Merino geolocation for a brief period so we don't ping it on every keystroke.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This is a small fix to city-based weather suggestions on desktop, which we want for 133
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1927960 should be uplifted first
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small optimization to weather suggestions with no user-visible changes. Weather suggestion are preffed off and are US-only when preffed on.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9434404 [details]
Bug 1928287 - Cache Merino geolocation for a brief period so we don't ping it on every keystroke.

Approved for 133.0b4

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/911b2eb3eb25