1928473 - Fix no-shadow and manifest section warnings (alphabetical) in search code

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

There's a few no-shadow warnings in the toolkit search code, and a couple of warnings about The manifest sections are not in alphabetical order, I think we could just clean those up.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1928473 - Fix no-shadow and manifest section warnings (alphabetical) in search code. r?mbeier!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3b696297414
Fix no-shadow and manifest section warnings (alphabetical) in search code. r=mbeier

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_searchbar_results.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/19759633f842e21bd024c32759702a7cfd299a5c

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e3b69629741400065e56f24fcd641168267ccbad&selectedTaskRun=JebRDPtrQVKNOkHQ4A31Pw.1

Failure log: https://treeherder.mozilla.org/logviewer?job_id=480749400&repo=autoland&lineNumber=9080

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/143dbed15cdb
Fix no-shadow and manifest section warnings (alphabetical) in search code. r=mbeier

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/143dbed15cdb