1928655 - Perma browser/components/urlbar/tests/browser/browser_focusContentDocumentEsc.js | URL bar value should have an address - Got "https://example.com", expected "example.com" - when Gecko 134 merges to beta on 2024-11-25

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[amarc]

Central-as-beta-simulation

How to run these simulations

Failure log
*Failure line:

TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_focusContentDocumentEsc.js | URL bar value should have an address - Got "https://example.com", expected "example.com"

Comment 1

[Collin Richards]

The failing value that's being reported is acceptable. The test should likely be amended to also accept 'https://example.com' as well. It could also be more general and just check if the url ends with example.com.

I'm not sure why in this test run it's returning https://example.com, maybe a different browser preference is being applied during that test run.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

browser.urlbar.trimHttps is true for Nightly and false for Beta and Release (source)
It can be set similar to other preferences in the test file.

Comment 3

[Collin Richards]

Attachment: Bug 1928655 - Amend focusContentDocumentEsc test for trimHttps. r=dao

Comment 4

[Intermittent Failures Robot]

34 failures in 730 pushes (0.047 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 34

Platform and build breakdown:

• linux1804-64-qr: 9
  • debug: 9
• linux1804-64-devedition-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-32-2009-qr: 2
  • debug: 2
• windows11-64-2009-qr: 4
  • debug: 4
• macosx1100-aarch64-shippable-qr: 2
  • opt: 2
• macosx1015-64-qr: 1
  • debug: 1
• windows11-32-2009-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2
• macosx1015-64-devedition-qr: 2
  • opt: 2
• windows11-64-2009-devedition-qr: 2
  • opt: 2
• windows11-64-2009-shippable-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1928655&startday=2024-11-01&endday=2024-11-01&tree=all

Comment 5

[Sandor Molnar[:smolnar]]

Patch is working in latest beta-simulation

Comment 6

[Intermittent Failures Robot]

34 failures in 4361 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 34

Platform and build breakdown:

• linux1804-64-qr: 9
  • debug: 9
• linux1804-64-devedition-qr: 2
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows11-32-2009-qr: 2
  • debug: 2
• windows11-64-2009-qr: 4
  • debug: 4
• macosx1100-aarch64-shippable-qr: 2
  • opt: 2
• macosx1015-64-qr: 1
  • debug: 1
• windows11-32-2009-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2
• macosx1015-64-devedition-qr: 2
  • opt: 2
• windows11-64-2009-devedition-qr: 2
  • opt: 2
• windows11-64-2009-shippable-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1928655&startday=2024-10-28&endday=2024-11-03&tree=all

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c8ae37fbf51
Amend focusContentDocumentEsc test for trimHttps. r=urlbar-reviewers,mak

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/9c8ae37fbf51

Comment 9

[Sandor Molnar[:smolnar]]

Verified fixed in today's beta simulation