1928661 - MenuMessage and browser-sync / panelUI not recording impressions properly

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Some of the refactoring I did in MenuMessage means that the showing-fxa-menu-message attribute is sometimes not set on the panel when it fires ViewShowing, meaning that the impression event isn't recorded.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1928661 - Make sure showing-fxa-menu-message attribute is set before ViewShowing fires for AppMenu or FxA avatar menu panels. r?pdahiya!

The async constructFxAMessage message was often not resolving before the ViewShowing
event fired, meaning that the attribute wasn't set in time.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87c2c74be9f5
Make sure showing-fxa-menu-message attribute is set before ViewShowing fires for AppMenu or FxA avatar menu panels. r=pdahiya,omc-reviewers

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/87c2c74be9f5

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1928661 - Make sure showing-fxa-menu-message attribute is set before ViewShowing fires for AppMenu or FxA avatar menu panels.

The async constructFxAMessage message was often not resolving before the ViewShowing
event fired, meaning that the attribute wasn't set in time.

Original Revision: https://phabricator.services.mozilla.com/D227668

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: None, but one of our experiments would be missing an important measurement for OMC message impressions.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Very, very little.
• Explanation of risk level: This is contained within a module that only executes during a specific messaging experiment that we're planning to run, and changes the order of certain events to ensure that "impressions" are properly recorded.
• String changes made/needed: None.
• Is Android affected?: no

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7b16813cb925