1928695 - New wpt failures in /css/css-cascade/scope-specificity.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 48929 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

• /css/css-cascade/scope-specificity.html [wpt.fyi]
  • @scope { & .b { } } and :where(:scope) .b: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1928673 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Daniel Holbert [:dholbert]]

I can reproduce the failure locally. With layout.css.at-scope.enabled set to true, this test (hosted on wpt.fyi) shows us passing 10 subtests and failing 1, with the failure reported like so:

Fail	@scope { & .b { } } and :where(:scope) .b

assert_equals: unscoped + scoped expected "2" but got "1"

The upstream PR has this note to explain itself:

The '&' selector, when it has no parent selector to draw from,
has a specificity of zero [1].

Blink already does the right thing. This CL just adds a new WPT
to enforce that behavior, and adjusts an existing tests which
expected specificity to be added.

dshin, could you take a look as part of your ongoing @scope work?

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1928695: Parent selector referring to implicit scope rule does not add specificity. r=#style

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ccabf34d30e
Parent selector referring to implicit scope rule does not add specificity. r=firefox-style-system-reviewers,emilio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5ccabf34d30e