1928744 - [wpt-sync] Sync PR 48936 - Allow new gesture scroll during snap animation

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48936 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48936
Details from upstream follow.

David Awogbemila <[e-mail]> wrote:

Allow new gesture scroll during snap animation

This patch fixes the issue in the linked bug by having InputHandler
de-latch at the start of a snap animation rather than at the end.
This allows a new gesture to latch onto a different scroll node
while the previous scroll node's snap animation is in progress.

In the unit test TrackAnimatingSnapTargetIds, a ScrollBegin call is
added to eschew violating the last_latched_scroll_type_ DCHECK[1] in
InputHandler::ScrollLatchedScroller.

[1] https://source.chromium.org/chromium/chromium/src/+/89812f5b31e3f078d2b0fa9c32904e7424c87cd9:cc/input/input_handler.cc;l=1786

Bug: 333708040
Change-Id: I7571a09644433ebea051a994935a987fdb25e704
Reviewed-on: https://chromium-review.googlesource.com/5826968
WPT-Export-Revision: 96475343b9bbbcef25276d256f99406adf7db310

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1be2418fcbaaffb052b9058a8d9b201e9dc07b0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 1

Chrome

TIMEOUT: 2
NOTRUN : 1

Safari

TIMEOUT: 2
NOTRUN : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-scroll-snap/unrelated-gesture-scroll-during-snap.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • gesture on separate scroll container works while another container snaps: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • gesture on separate snap container works while another container snaps: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92a3b7192503
[wpt PR 48936] - Allow new gesture scroll during snap animation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/797c3b75b859
[wpt PR 48936] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/92a3b7192503
https://hg.mozilla.org/mozilla-central/rev/797c3b75b859