1928758 - Event retargeting should not reposition the event if the target frame has not changed

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Botond Ballo [:botond]]

Noticed this while helping Alex investigate bug 1914368.

Our event retargeting code can potentially change the target frame of an event from an initial target computed here to a final target computed here.

Since the target frame may have chaged, the event's position (mRefPoint) is also recomputed, which happens here.

(Bug 1914368 seems to be caused by a bug in this recomputation.)

If the target frame did not actually change, the work done to recompute the event position is unnecessary, and could be skipped.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1928758 - Avoid repositioning event if its target has not changed. r=ajakobi

The repositioning should be a no-op in such cases.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a44e14892924
Avoid repositioning event if its target has not changed. r=ajakobi

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/a44e14892924