192877 - State changes on bugs w/ dependancies cause "Use of uninitialized values"

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect, P1)

Description

[Dave Miller [:justdave]]

Getting this in my error logs on bugscape

[Tue Feb 11 17:45:04 2003] process_bug.cgi: Use of uninitialized value in string
eq at Bugzilla/BugMail.pm line 780.

Comment 1

[Dave Miller [:justdave]]

*** Bug 192879 has been marked as a duplicate of this bug. ***

Comment 2

[J. Paul Reed [:preed]]

I'm looking at error logs on landfill, and I'm seeing this also in line 790 (as
well as 780):

[Tue Feb 11 12:56:54 2003] process_bug.cgi: Use of uninitialized value in string
eq at Bugzilla/BugMail.pm line 780.
[Tue Feb 11 12:56:54 2003] process_bug.cgi: Use of uninitialized value in string
ne at Bugzilla/BugMail.pm line 790.

This code looks to have been added as part of bug 24789.

Justdave: can you confirm that these errors were *not* appearing before bug
124174 was checked in?

Comment 3

[J. Paul Reed [:preed]]

Oh, could you also see if you can find a way to reproduce?

I can't seem to get it to fire on just adding a comment or changing fields on
any old bug, so...

Comment 4

[Dave Miller [:justdave]]

no, because:
a) Bugzilla/BugMail.pm didn't exist prior to that checkin
b) we apparently weren't trapping stderr from processmail

Comment 5

[J. Paul Reed [:preed]]

Steps to repro:

1. Create a new bug.
2. Enter a dependancy (a blocking bug)
3. Accept the bug
4. Resolve the bug (you should see it here)
5. Reopen the bug (you should see it here, too).

Comment 6

[J. Paul Reed [:preed]]

Attachment: v1

Fixes the "uninitialized value" errors. 

Looks to be an original bug from bug 24789; if we're creating a mail for a
dependant bug, we're not going to be changing the estimated/time remaining
fields on the *dependent* bugs and those fields aren't present on dep bugs.

Comment 7

[J. Paul Reed [:preed]]

Attachment: v2

Make the patch actually make sense (just for bbaetz ;-)

Comment 8

[J. Paul Reed [:preed]]

Attachment: Simpler fix

Ok... this is the simpler (and probably most correct... which is... good)
version of this patch.

Comment 9

[J. Paul Reed [:preed]]

Comment on attachment 114534 [details] [diff] [review]
Simpler fix

There are some whitespace issues with this patch; it'll be fixed for checkin...
but the concept should be clear.

Comment 10

[Dave Miller [:justdave]]

Comment on attachment 114534 [details] [diff] [review]
Simpler fix

yeah, looks pretty obvious.

Comment 11

[J. Paul Reed [:preed]]

Checking in BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.2; previous revision: 1.1
done