1929000 - values set with sessions.setTabValue lost when moving tabs between windows

Status: NEW

(Firefox :: Session Restore, defect, P3)

Description

[Yuri Khan]

Attachment: webext-tabvalues.zip

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:132.0) Gecko/20100101 Firefox/132.0

Steps to reproduce:

0. Start firefox -ProfileManager.
1. Create a clean profile. Start Firefox.
   • observed: a single window with two tabs
2. Open a new window.
3. In the new window’s initial tab, open about:debugging, switch to the This Firefox section, click Load Temporary Add-on button. Point to the directory containing the files extracted from the attached archive.
4. Click the Inspect button for the extension loaded in step 3. In the Developer Tools window that opens, switch to the Console tab.
5. In the console, enter: await browser.windows.getAll({ populate: true }). Expand the resulting array, both its elements, their .tabs arrays, and their elements .
   • Observed (for example): window id 1 with tabs id 1 (Firefox Privacy Notice) and 2 (Welcome to Firefox), and window id 54 with tab id 3 (Debugging).
6. In the console, enter: await browser.sessions.setTabValue(1, 'key', 'value').
7. Check that the value was set: await browser.sessions.getTabValue(1, 'key').
   • Observed: "value"
8. Drag the Firefox Privacy Notice tab from window 1 to window 54.
9. Attempt to retrieve the moved tab’s custom value: await browser.sessions.getTabValue(1, 'key').

Actual results:

Observed: undefined.

Expected results:

Expected: "value".

Comment 1

[Yuri Khan]

I have traced the issue to the window._gBrowser.adoptTab method that creates a new tab in the target window, then calls swapBrowsersAndCloseOther which teleports the tab’s state into the new tab and then kills the original. I imagine swapBrowsersAndCloseOther should be re-associating the original tab’s custom values to the new tab.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Yuri Khan]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #2)

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Hm. I’d maybe suggest Firefox::Tabbed Browser or WebExtensions::General.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Yuri Khan from comment #1)

I have traced the issue to the window._gBrowser.adoptTab method that creates a new tab in the target window, then calls swapBrowsersAndCloseOther which teleports the tab’s state into the new tab and then kills the original. I imagine swapBrowsersAndCloseOther should be re-associating the original tab’s custom values to the new tab.

We already copy over permanentKey, so perhaps session restore could use that to keep track of the tab data.

Comment 5

[Rares Doghi, Desktop QA]

I was able to reproduce this issue in our latest Firefox Builds. I will update the flags for this issue.