1929006 - Accessibility components/Button.js isn't used anywhere

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, task)

Description

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

See https://searchfox.org/mozilla-central/search?q=components%2FButton.js&path=&case=false&regexp=false
The file isn't loaded from any other places, so we can probably remove it and cleanup the associated CSS rules

Comment 1

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

Attachment: Bug 1929006 - [devtools] Delete unused devtools/client/accessibility/components/Button.js. r=#devtools.

The components weren't used anywhere. We can also remove selectors and rules that were targetting
classes only used in this file.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6de8e8b78185
[devtools] Delete unused  devtools/client/accessibility/components/Button.js. r=devtools-reviewers,bomsy.

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing devtools failures in browser_accessibility_print_to_json.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/client/accessibility/test/browser/browser_accessibility_print_to_json.js | Uncaught exception in test bound a11YPanelTask - at chrome://mochitests/content/browser/devtools/client/accessibility/test/browser/head.js:563 - TypeError: can't access property "querySelector", row is undefined

Comment 4

[Nicolas Chevobbe [:nchevobbe][PTO back September 7]]

sorry about that, I'm having a look right now

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/080d4a9badc5
[devtools] Delete unused devtools/client/accessibility/components/Button.js. r=devtools-reviewers,bomsy.

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/080d4a9badc5