1929007 - Store console API calls in recorded tracing profiles

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

Thanks to bug 1828100, we can now easily store all console API calls into the profiler records by toggling logging.console pref to 5.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1929007 - [devtools] Collect console API calls when tracing from DevTools.

Because the tracer actor runs in the content process, the preference toggling logic
has to be done in some code running in the parent process: TargetConfiguration.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a603b65c102
[devtools] Collect console API calls when tracing from DevTools. r=dthayer

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0a603b65c102

Comment 4

[Nicolas Chevobbe [:nchevobbe] [PTO - back January 24]]

We got a regression from this (or Bug 1929004). I'm not filing a bug as it seems expected to get a regression as we're collecting more things, but it may be nice to check if we were expecting changes of that magnitude

---

Ratio	Test	Platform	Options	Absolute values (old vs new)
437%	damp jstracer.profiler-collection-performance.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	142.58 -> 765.49
338%	damp jstracer.profiler-collection-performance.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	98.48 -> 431.40
337%	damp jstracer.profiler-collection-performance.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	99.32 -> 433.94
271%	damp jstracer.profiler-collection-performance.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	64.34 -> 238.70