XMPP chat can't handle messages inside CDATA XML
Categories
(Chat Core :: XMPP, defect)
Tracking
(thunderbird_esr128 fixed, thunderbird134 fixed)
People
(Reporter: lukas.buchs, Assigned: clokep)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
corey
:
approval-comm-esr128+
|
Details | Review |
Steps to reproduce:
Some XMPP clients (for example eM Client) send XMPP chat messages inside a CDATA element. They are not shown in Thunderbird.
The XMPP XML looks like this:
<body><![CDATA[this is my chat message text]]></body>
thunderbird only accept messages like this:
<body>this is my chat message text</body>
Actual results:
Thunderbird does not show the message
Expected results:
Thunderbird should show the message
|
Assignee | |
Comment 1•4 months ago
|
||
|
||
Updated•4 months ago
|
|
|
Assignee | |
Comment 2•4 months ago
|
||
Looks like we don't handle CDATA at all...
|
|
Assignee | |
Updated•4 months ago
|
Pushed by john@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/71ce935d70a6
Fix handling of CDATA in XMPP streams. r=mkmelin
|
||
Updated•4 months ago
|
|
||
Updated•3 months ago
|
|
|
Assignee | |
Comment 4•3 months ago
|
||
Comment on attachment 9435203 [details]
Bug 1929011 - Fix handling of CDATA in XMPP streams. r=#thunderbird-reviewers
[Approval Request Comment]
Regression caused by (bug #): N/A (always a bug)
User impact if declined: Users may miss XMPP messages sent by other clients.
Testing completed (on c-c, etc.): Been on comm-central for ~1 month with no further bug reports.
Risk to taking this patch (and alternatives if risky): Messages could be corrupted if the parsing is incorrect.
|
||
Comment 5•3 months ago
|
||
Comment on attachment 9435203 [details]
Bug 1929011 - Fix handling of CDATA in XMPP streams. r=#thunderbird-reviewers
[Triage Comment]
Approved for esr128
|
||
Comment 6•3 months ago
|
||
| bugherder uplift | ||
Thunderbird 128.5.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/8f6e8a39632f
Description
•