1929055 - Ensure globals added by explicit resource management are handled correctly by xray

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Comment 1

[Debadree Chatterjee]

Attachment: Bug 1929055 - Update xray to handle explicit resource management globals. r?arai!

Depends on D227770

Comment 2

[Debadree Chatterjee]

Attachment: Bug 1929055 - Add tests for xray on explicit resource management globals. r?arai!

Depends on D227666

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8285e187688
Update xray to handle explicit resource management globals. r=arai

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e8285e187688

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f5ac8b278f8
Add tests for xray on explicit resource management globals. r=arai

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures @ test_xrayToExplicitResourceManagement

Backout link: https://hg.mozilla.org/integration/autoland/rev/723946b9a47990aa6253585366bb18863de4df33

Push with failures

Failure log -> js/xpconnect/tests/chrome/test_xrayToExplicitResourceManagement.html

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb04d0dfa662
Add tests for xray on explicit resource management globals. r=arai

Comment 8

[Debadree Chatterjee]

Have relanded the patch with changes.

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fb04d0dfa662

Comment 10

[Mayank Bansal]

This also lead to a 560 byte increase in base contetn js fission. This is well below any threshold, and is only a FYI.

Comment 11

[Debadree Chatterjee]

Thank you so much for investigating! do you think this could be the reason for https://bugzilla.mozilla.org/show_bug.cgi?id=1932110 ?