1929084 - [Menu Redesign] Preserve scrolled state on the main menu when entering back from the sub-menu.

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Aarjav [:aarjav]]

Steps to reproduce

1. Open the menu.
2. Scroll the main menu.
3. Enter the 'Tools' sub-menu.
4. Go back to main menu.

Expected behavior

• On going back, the user will see the same scrolled level/state of the main menu as before they entered the sub-menu.

Actual behavior

• Every time the user exits the sub-menu, the scrolled state of the main menu is reset.

Device information

• Firefox version: nightly
• Android device model: pixel 6
• Android OS version:

Any additional information?

Comment 1

[Zac McKenney [:zmckenney]]

Attachment: menu_scrollstate_test.mp4

:aarjav, we currently maintain the state of the menu for whether it is expanded or not. If it is expanded and a user has scrolled the list when they enter a submenu and return it is back to the top of this list as you state. I think we can leave this open as a future enhancement but I don't believe this is a blocking behavior as it is a very minor issue. If it's alright with you I'd like to put this as follow-up work if we decide it's important.

Comment 2

[Aarjav [:aarjav]]

I agree this doesn't need to block beta, but I feel this would be a basic expectation of the user, so if it is a considerable low uplift, it would be great if we can include it. Also, because for people who are getting used to the new sub-menu design, this specific behavior would start to become an issue.
But I would ask Channing to take the final call on this.

Comment 3

[Zac McKenney [:zmckenney]]

Ok, I'll move it to the followup work for now and we can move it as needed once Channing has reviewed it.

Comment 4

[Channing]

(In reply to Zac McKenney [:zmckenney] from comment #1)

Created attachment 9437278 [details]
menu_scrollstate_test.mp4

:aarjav, we currently maintain the state of the menu for whether it is expanded or not. If it is expanded and a user has scrolled the list when they enter a submenu and return it is back to the top of this list as you state. I think we can leave this open as a future enhancement but I don't believe this is a blocking behavior as it is a very minor issue. If it's alright with you I'd like to put this as follow-up work if we decide it's important.

I agree, it doesn't need to block beta.

Comment 5

[Aarjav [:aarjav]]

Zac, can we keep this as a Release blocker? but last on the list? If it is a simple uplift it will be great if we can have this incorporated in before it reaches the release experiment.
If there are other more serious bugs for release blocker, we can revisit this to prioritize it.

Comment 6

[Sanchaai [:sanchaai]]

Attachment: Bug 1929084 - Preserve scrolled state on the main menu when entering back from the sub-menu. r=giorga

Preserve the scrolled state of the main menu so that when returning to it from a sub-menu, the main menu's scrolled state does not get reset.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9b68728dcc6
Preserve scrolled state on the main menu when entering back from the sub-menu. r=giorga,android-reviewers

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b9b68728dcc6