1929118 - [css-animations-2][css-transitions-2] Add animation object to animation/transition events.

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, enhancement)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#9010.

[css-animations-2][css-transitions-2] Add animation object to animation/transition events.

• RESOLVED: Add an animation property to the animation*/transition* events that contains the relevant Animation object (CSSAnimation and CSSTransition respectively)

Discussion.

Comment 1

[Kanaru Sato [:canalun]]

Attachment: Bug 1929118 - Add tests for animation property of AnimationEvent and TransitionEvent. r?birtles

In the subsequent patch, animation property will be added in AnimationEvent and TransitionEvent.
This patch adds tests for that.

Comment 2

[Kanaru Sato [:canalun]]

Attachment: Bug 1929118 - Add animation property to AnimationEvent and TransitionEvent. r?birtles

This patch adds animation property to AnimationEvent and TransitionEvent.
This prop has the corresponding CSSAnimation and CSSTransition respectively.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f91a43064d99
https://hg.mozilla.org/integration/autoland/rev/56704568a20a
Add tests for animation property of AnimationEvent and TransitionEvent. r=birtles
https://github.com/mozilla-firefox/firefox/commit/5b0bd23c7d00
https://hg.mozilla.org/integration/autoland/rev/e5b1938e4631
Add animation property to AnimationEvent and TransitionEvent. r=birtles,webidl,smaug

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dae6164359c0
https://hg.mozilla.org/integration/autoland/rev/8fcee53df007
Revert "Bug 1929118 - Add animation property to AnimationEvent and TransitionEvent. r=birtles,webidl,smaug" for causing failures complaining about Animation bfcache.

Comment 5

[Atila Butkovits]

Backed out for causing failures complaining about Animation bfcache.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8fcee53df007

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e5b1938e463109ae9480f8fe128bfb956348b3a3&selectedTaskRun=cr0Dv2K7TkmjYCIlxfMHdw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=562753994&repo=autoland&task=cr0Dv2K7TkmjYCIlxfMHdw.0&lineNumber=2276

Comment 6

[Kanaru Sato [:canalun]]

Thank you, I'll fix it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/238e07aff6e9
https://hg.mozilla.org/integration/autoland/rev/f8c4fdcf52fd
Add tests for animation property of AnimationEvent and TransitionEvent. r=birtles
https://github.com/mozilla-firefox/firefox/commit/794e47d452ac
https://hg.mozilla.org/integration/autoland/rev/f9b58ec81b5b
Add animation property to AnimationEvent and TransitionEvent. r=birtles,webidl,smaug

Comment 8

[Tooru Fujisawa [:arai]]

Re-landed given:

• bug 2027803 is also backed out for the same failure
• bug 2027803 is landed before this bug's patches, and backed out after them
• The failure itself is pre-existing intermittent failure

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59512 for changes under testing/web-platform/tests

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f8c4fdcf52fd
https://hg.mozilla.org/mozilla-central/rev/f9b58ec81b5b

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Kanaru Sato [:canalun]]

Attachment: Bug 1929118 - Stop including CSS(Animation|Transition) headers from ContentEvents header. r?emilio

As a follow-up on D295112, this patch removes the inclusion of CSS(Animation|Transition)
headers from ContentEvents.h by forward-declaring those classes and moving the implementations
that require complete types into a new ContentEvents.cpp. This also required the followings:

• moving AnimationEventDispatcher::Dispatch() out of the header, because it also needs the
  full definitions of CSS(Animation|Transition).
• adding CSS(Animation|Transition) headers to Event.cpp, which needs the full definitions and
  had obtained them by including ContentEvents.h before this patch.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14ddbe307cc4
https://hg.mozilla.org/integration/autoland/rev/e5e8a9faca3b
Stop including CSS(Animation|Transition) headers from ContentEvents header. r=emilio,masayuki

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e5e8a9faca3b

Comment 16

[Hamish Willee]

FF152 MDN Docs work for this can be tracked in https://github.com/mdn/content/issues/44164