1929178 - <input> textfield as -webkit-box flex item doesn't shrink below intrinsic size in Firefox (but does shrink in other browsers)

Status: VERIFIED FIXED

(Core :: Layout: Flexbox, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

[This is the underlying bug behind WebCompat Site Report Bug 1925259.]

STR:

1. Load attached testcsae.

EXPECTED RESULTS:
Textfield should shrink to fit inside teal box.

ACTUAL RESULTS:
Textfield does not shrink enough; it overflows quite a ways beyond the right side of the teal box.

Chrome 132.0.6793.2 (Official Build) dev (64-bit) and Epiphany (gnome-web) version 47 both give EXPECTED RESULTS.
Firefox Nightly 134.0a1 (2024-11-04) (64-bit) gives ACTUAL RESULTS.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1929178 Part 1 - Add a helper to get percentage basis when computing specified size suggestion. r?dholbert

With this helper, we are able to get percentage basis only when needed.

While I'm here, I revised the code comment by adopting the review comments in
https://phabricator.services.mozilla.com/D120519#inline-666075

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1929178 Part 2 - Make PartiallyResolveAutoMinSize() a nsFlexContainer's protected member function. r?dholbert

This patch makes it easier to use IsLegacyBox(this) to test whether the flex
container is legacy or not.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 1929178 Part 3 - Allow flex item in legacy flex container to shrink below its automatic minimum size. r?dholbert

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/785e1d3da060
Part 1 - Add a helper to get percentage basis when computing specified size suggestion. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/c05545b2d1f6
Part 2 - Make PartiallyResolveAutoMinSize() a nsFlexContainer's protected member function. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/8c9ad1da1fb0
Part 3 - Allow flex item in legacy flex container to shrink below its automatic minimum size. r=dholbert

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49358 for changes under testing/web-platform/tests

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/785e1d3da060
https://hg.mozilla.org/mozilla-central/rev/c05545b2d1f6
https://hg.mozilla.org/mozilla-central/rev/8c9ad1da1fb0

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:TYLin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

This bug has existed for years. Let's have it ride the train.

Comment 11

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly 134.0a1 from 2024-11-04, using Windows 11 while loading the test case attached in Comment 0.
Verified as fixed on Firefox 135.0b2 using Windows 11, macOS 13.6 and Ubuntu 22.04. Textfield shrinks inside teal box.