1929284 - Update Temporal implementation to draft November 1, 2024

Status: ASSIGNED

(Core :: JavaScript: Standard Library, task, P3)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 1: Various editorial updates. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/0ce8f4bb9a251cf195dfdd4e0fafcb19d281ef3c
• https://github.com/tc39/proposal-temporal/commit/3ad94d9fbb02c172e5eb8bd5a4552d050e69d255

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 2: Disallow rounding to increment while balancing to calendar unit. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/74aa2309db9e5edfe520770fb2e6758a56f8ba8f

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 3: Sync TemporalParser. r=#spidermonkey-reviewers!

• Update spec references to match the current spec text more closely.
• Use MOZ_TRY_VAR to reduce code duplication.
• Add ParsedZonedDateTime to reduce the number of out-params for
  ParseTemporalZonedDateTimeString and ParseTemporalRelativeToString.
• Also track "start-of-day" in preparation for the next part.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 4: Handle "start of day" separately from "midnight". r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/c0aaa8218958ace4bba08a4e6f0b6dcff7354703

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 5: Remove precalculated date-time parameters and sync operation names. r=#spidermonkey-reviewers!

• Remove precalculated date-time parameters from AddZonedDateTime and DifferenceZonedDateTimeWithRounding.
• Rename GetPlainDateTimeFor to GetISODateTimeFor per current spec.
• Inline GetOffsetStringFor into its single caller per current spec.

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 6: Sync processing of "options" in ToTemporal operations. r=#spidermonkey-reviewers!

The options parameter is now (again) handled in the various ToTemporalThing
operations.

Also merge ToTemporalDuration and ToTemporalDurationRecord per latest spec.

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 7: Sync normalize duration operations. r=#spidermonkey-reviewers!

Sync the operation names and add two new operations
NormalizeDurationWith24HourDays and NormalizeDurationWithoutTime.

NOTE: Later spec updates have renamed these operations. Later parts in this
patch stack will update the operations to their current names.

Comment 8

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 8: Add ISODateWithinLimits. r=#spidermonkey-reviewers!

The spec now has a separate ISODateWithinLimits operation.

Comment 9

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 9: Synchronise operations to add durations. r=#spidermonkey-reviewers!

Spec operations have been renamed to all start with "AddDurationTo" and there
were some additional minor implementation changes.

• Change AddTime, BalanceTime, and RoundTime to return a TimeRecord (per spec).
• New callers to AddTime and BalanceTime require int64_t for days, so using
  int64_t for all three functions is now necessary.
• The new TODO notes in AddDurationToYearMonth will be addressed when updating
  the Temporal Fields operations.

Comment 10

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 10: Merge CanonicalizeUValue into IsBuiltinCalendar. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/037015b33d19abe7c07e29a2a1f2f9af627787e0

Comment 11

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 11: Sync steps in PlainYearMonth. r=#spidermonkey-reviewers!

• Sync step comments.
• Reorder steps to match current proposal.
• Add TODO notes for still missing changes.

Comment 12

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 12: Add missing include guards. r=#spidermonkey-reviewers!

Drive-by changes:

• Make the MonthCodes constructor a bit more readable.
• Change constants in monthcodes namespace to avoid a parser error in the CDT indexer.

Comment 13

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 13: Sync Calendar Fields operations. r=#spidermonkey-reviewers!

"Temporal Fields" are now "Calendar Fields" in the spec. Multiple operations
have been simplified now that user-defined calendars have been removed. Sync
all operations which use "Calendar Fields" to match the current spec text.

Comment 14

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 14: Sync step comments for Temporal.Instant. r=#spidermonkey-reviewers!

Comment 15

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 15: Remove individual AOs for each calendar field. r=#spidermonkey-reviewers!

Changes from:
https://github.com/tc39/proposal-temporal/commit/9202f1f4ffc436e0948097092cff6c1ec37ba530

Comment 16

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 16: Reorder more Calendar operations. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/59a95b429cad320c092f5a28cc21c2459de70937
• https://github.com/tc39/proposal-temporal/commit/77eddda7c1a427b79baa200d05c474d3da53d233
• https://github.com/tc39/proposal-temporal/commit/0a48e9792856910270b14d8778b4f9ee0331b02a

Comment 17

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 17: More editorial changes. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/805b4adbb76b8001aeb761b21f05defca0272cc5
• https://github.com/tc39/proposal-temporal/commit/0497ce3a7d3c64a07493d1a20920ccae5726b13d
• https://github.com/tc39/proposal-temporal/commit/2ecbec67efc8b8bd31098201d459349c398386f0
• https://github.com/tc39/proposal-temporal/commit/f59e41ff9d135de0a22fe408f70cffe68e2a243d
• https://github.com/tc39/proposal-temporal/commit/283cd63d51f1ddc68b1029568451ed88c9e495c6
• https://github.com/tc39/proposal-temporal/commit/a820980cf7a970bc462cc8c1c85ab71aa66ecb30
• https://github.com/tc39/proposal-temporal/commit/10f967c6ec9446c412a411e04046d320dcf825a4

Comment 18

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 18: Sync Calendar{Date,YearMonth,MonthDay}FromFields. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/3685b60d70a4c021398e93138dd649c36303dc29
• https://github.com/tc39/proposal-temporal/commit/487d272cf2f6e25201783982596da3f9fa6357b0
• https://github.com/tc39/proposal-temporal/commit/8f903388cb23b2635201ead261d15e99c429e14b
• https://github.com/tc39/proposal-temporal/commit/5a1fcc3ac9a0923065ee6af5ec733ceb7457bffa
• https://github.com/tc39/proposal-temporal/commit/f3997ebab3e5ecfd018167337f14d48a924fdb55
• https://github.com/tc39/proposal-temporal/commit/0406eb1342197aa51385e9dde8d657ac577c5a63
• https://github.com/tc39/proposal-temporal/commit/444ec937cca777c2225132df6ff5d860da66bb72
• https://github.com/tc39/proposal-temporal/commit/1d4d62e33cc276957072b53fecec365d83aec3e2
• https://github.com/tc39/proposal-temporal/commit/da5b3c02db2d36e5e91b84d27de829658620fe64

Comment 19

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 19: Merge operations into CalendarDateAdd and CalendarDateUntil. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/54f153374a1e885af3139ebf37b4b70c5a1a69c4
• https://github.com/tc39/proposal-temporal/commit/ae86a91b4c900cc9a3124874189620883359270e
• https://github.com/tc39/proposal-temporal/commit/2eb79f1dbd6837a136457e81d0c827d6d7464502
• https://github.com/tc39/proposal-temporal/commit/3374959b9acb5e361af6cfca0c3f8bde0f40dfaf

Comment 20

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 20: Sync BalanceISODate. r=#spidermonkey-reviewers!

Comment 21

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 21: Nanoseconds difference between two consecutive days fits into int64. r=#spidermonkey-reviewers!

We don't have to use Int128, because without user-defined time zones, it's guaranteed
that the values fit into int64_t.

Comment 22

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 22: More editorial changes. r=#spidermonkey-reviewers!

Changes from:

• https://github.com/tc39/proposal-temporal/commit/966991b9d2ed0f32733487e6e4557e5b3a51b003
• https://github.com/tc39/proposal-temporal/commit/188f484a4908702f05b42ed168883a90b3aef536
• https://github.com/tc39/proposal-temporal/commit/a36ce7c2b73b2ce4c869be5bb443256d40016f0d

Comment 23

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 23: Sync PlainTime. r=#spidermonkey-reviewers!

Sync all operations and step references to the current draft proposal.

Comment 24

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 24: Sync Duration.prototype.compare. r=#spidermonkey-reviewers!

options are now processed before the early return.

Drive-by changes:

• Update names for CompareTimeDuration, TimeDurationSign, and DateDurationDays.
• Pass ZonedDateTime to AddZonedDateTime and DifferenceZonedDateTimeWithRounding
  instead of reading the individual fields in the callers.

Comment 25

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 25: Add missing range check to PlainDateTime.prototype.toString. r=#spidermonkey-reviewers!

Added as part of:
https://github.com/tc39/proposal-temporal/commit/b889242067a7bc1d3a433ec9fa7149a72c18a533

Comment 26

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 26: Constrain day when year is present in CalendarMonthDayToISOReferenceDate. r=#spidermonkey-reviewers!

See also:

• https://github.com/tc39/proposal-temporal/issues/2863
• https://github.com/tc39/proposal-temporal/issues/2864

Comment 27

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 27: Add missing date-time range checks. r=#spidermonkey-reviewers!

Reported as https://github.com/tc39/proposal-temporal/issues/3015.

Comment 28

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 28: Sync Temporal.Now. r=#spidermonkey-reviewers!

Sync all operations and step references to the current draft proposal.

Comment 29

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 29: Sort CalendarField enum values. r=#spidermonkey-reviewers!

This allows removing SortedEnumSet.

Comment 30

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 30: Rename date-time classes to match spec uses. r=#spidermonkey-reviewers!

Perform the following renames:

• PlainDate(Time) -> ISODate(Time)
• PlainTime -> Time
• PlainXXXWithCalendar -> PlainXXX.

Comment 31

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 31: Sync TimeZone. r=#spidermonkey-reviewers!

Sync all operations and step references to the current draft proposal.

Comment 32

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 32: Rename Instant -> EpochNanoseconds. r=#spidermonkey-reviewers!

The spec no longer passes Temporal.Instant objects around and instead directly
uses the nanoseconds amount. Rename the Instant struct to EpochNanoseconds to
match the current spec use more closely.

Comment 33

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 33: Remove TimeDuration. r=#spidermonkey-reviewers!

The spec now also defines a Time Duration value, so it's confusing when an
internal implementation type is named TimeDuration.

Comment 34

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 34: Rename NormalizedDuration -> InternalDuration and NormalizedTimeDuration -> TimeDuration. r=#spidermonkey-reviewers!

Align duration records with the current spec names.

Comment 35

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 35: Update DifferenceISODate implementation. r=#spidermonkey-reviewers!

Implement the changes from:

• https://github.com/tc39/proposal-temporal/pull/2762
• https://github.com/tc39/proposal-temporal/pull/2759

Comment 36

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 36: Sync Duration rounding. r=#spidermonkey-reviewers!

Rounding operations were reordered and split into different operations. Update
everything to match the current spec text.

Comment 37

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 37: Sync Temporal.PlainDateTime. r=#spidermonkey-reviewers!

Sync all operations and step references to the current draft proposal.

Comment 38

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 38: Replace ToTemporalCalendarIdentifier. r=#spidermonkey-reviewers!

Rename ToTemporalCalendarIdentifier to CalendarIdentifier to avoid confusion
with the spec operation ToTemporalCalendarIdentifier.

Comment 39

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 39: Avoid repeating constants for minimum and maximum valid date. r=#spidermonkey-reviewers!

Comment 40

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 40: Sync PlainDate. r=#spidermonkey-reviewers!

Sync all operations and step references to the current draft proposal.

Comment 41

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 41: Remove unused code and avoid duplicated code for time duration to days. r=#spidermonkey-reviewers!

Comment 42

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 42: Sync ZonedDateTime. r=#spidermonkey-reviewers!

Sync all operations and step references to the current draft proposal.

Comment 43

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 43: Sync Temporal.Duration. r=#spidermonkey-reviewers!

Sync all operations and step references to the current draft proposal.

Comment 44

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 44: Implement CalendarDateAdd for non-ISO calendars. r=#spidermonkey-reviewers!

ICU4X doesn't yet provide this operation, so we have to write our own implementation.

Comment 45

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 45: Add a workaround for an ICU4X bug. r=#spidermonkey-reviewers!

Workaround for https://github.com/unicode-org/icu4x/issues/5070.

Comment 46

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 46: Implement DifferenceCalendarDate. r=#spidermonkey-reviewers!

ICU4X doesn't yet provide a public API for this operation, so we have to write
our own implementation.

Comment 47

[André Bargull [:anba]]

Attachment: Bug 1929284 - Part 47: Enable now passing tests. r=#spidermonkey-reviewers!

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adaacc03dc4f
Part 1: Various editorial updates. r=dminor
https://hg.mozilla.org/integration/autoland/rev/b6f30453153e
Part 2: Disallow rounding to increment while balancing to calendar unit. r=dminor
https://hg.mozilla.org/integration/autoland/rev/ee257f72e4c3
Part 3: Sync TemporalParser. r=dminor
https://hg.mozilla.org/integration/autoland/rev/93b34d6de713
Part 4: Handle "start of day" separately from "midnight". r=dminor
https://hg.mozilla.org/integration/autoland/rev/63c3e38aa87a
Part 5: Remove precalculated date-time parameters and sync operation names. r=dminor
https://hg.mozilla.org/integration/autoland/rev/6ef814f5cfef
Part 6: Sync processing of "options" in ToTemporal operations. r=dminor
https://hg.mozilla.org/integration/autoland/rev/21548a9ebb44
Part 7: Sync normalize duration operations. r=dminor
https://hg.mozilla.org/integration/autoland/rev/0b9705544e7b
Part 8: Add ISODateWithinLimits. r=dminor
https://hg.mozilla.org/integration/autoland/rev/10a3237bfe6b
Part 9: Synchronise operations to add durations. r=dminor
https://hg.mozilla.org/integration/autoland/rev/2c0dd60a07fe
Part 10: Merge CanonicalizeUValue into IsBuiltinCalendar. r=dminor
https://hg.mozilla.org/integration/autoland/rev/15302cb66051
Part 11: Sync steps in PlainYearMonth. r=dminor
https://hg.mozilla.org/integration/autoland/rev/347f3afc24e7
Part 12: Add missing include guards. r=dminor
https://hg.mozilla.org/integration/autoland/rev/a65d72c20c3a
Part 13: Sync Calendar Fields operations. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/0a8562654882
Part 14: Sync step comments for Temporal.Instant. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/36a71a646110
Part 15: Remove individual AOs for each calendar field. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/efb3a6becd0f
Part 16: Reorder more Calendar operations. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/7c84fde489b3
Part 17: More editorial changes. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/e9dd7a737ebe
Part 18: Sync Calendar{Date,YearMonth,MonthDay}FromFields. r=dminor
https://hg.mozilla.org/integration/autoland/rev/fd8642b60cc7
Part 19: Merge operations into CalendarDateAdd and CalendarDateUntil. r=dminor
https://hg.mozilla.org/integration/autoland/rev/e12cbfccea67
Part 20: Sync BalanceISODate. r=dminor