1929466 - landing jobs errors should return JSON objects

Status: NEW

(Conduit :: Lando, defect, P3)

Description

[Olivier Mehani [:shtrom]]

Two landing jobs tests remain skipped after bug 1915712 https://github.com/mozilla-conduit/lando/blob/c56c9faf90b1e4bb80dbd89b2365d20313f0e37b/src/lando/api/tests/test_landing_job.py#L77-L102

This is due to the fact that those error paths do not return JsonResponse, but lead to exceptions getting thrown, which in turns get transformed via HTML views.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-conduit/lando] landing_jobs: return JSON responses for exceptions (bug 1929466) (#152)

Comment 2

[Olivier Mehani [:shtrom]]

Two-stage fix:

1. unskip the tests, but only check the HTTP status code (not the response body)
2. fix the response body (either by replacing exceptions with JsonResponses, or updating the Exception view to return JSON rather than HTML)